Fix: Glibc error by pegging ubuntu version, appimage include extras like breez_sdk#3397
Merged
arcbtc merged 14 commits intolnbits:devfrom Oct 10, 2025
Merged
Fix: Glibc error by pegging ubuntu version, appimage include extras like breez_sdk#3397arcbtc merged 14 commits intolnbits:devfrom
arcbtc merged 14 commits intolnbits:devfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #3397 +/- ##
=======================================
Coverage 56.13% 56.13%
=======================================
Files 116 116
Lines 15115 15116 +1
=======================================
+ Hits 8485 8486 +1
Misses 6630 6630 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
dni
reviewed
Oct 10, 2025
| chmod +x "$APPIMAGE_NAME" | ||
| echo "APPIMAGE_NAME=$APPIMAGE_NAME" >> $GITHUB_ENV | ||
|
|
||
| # 🔎 quick audit: show glibc versions referenced by the binary |
dni
reviewed
Oct 10, 2025
| echo "Runner glibc:" | ||
| ldd --version | head -n1 || true | ||
| echo "Symbols needed by lnbits:" | ||
| strings "$APPIMAGE_NAME" | grep -o 'GLIBC_[0-9.]*' | sort -u || true |
dni
reviewed
Oct 10, 2025
Comment on lines
+16
to
+24
| if ! command -v curl >/dev/null 2>&1 || ! command -v git >/dev/null 2>&1; then | ||
| sudo apt-get update -y | ||
| sudo apt-get install -y curl git | ||
| fi | ||
|
|
||
| # Install Python 3.10 and distutils non-interactively | ||
| sudo apt install -y python3.10 python3.10-distutils | ||
| # System build deps and secp headers | ||
| if command -v apt-get >/dev/null 2>&1; then | ||
| sudo apt-get update -y | ||
| sudo apt-get install -y \ |
Member
There was a problem hiding this comment.
the if and the splitted apt-get commands are unecessary
dni
approved these changes
Oct 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.