Skip to content

refactor: move /payments into vue component#3414

Merged
dni merged 3 commits intodevfrom
refactor/page-component
Oct 31, 2025
Merged

refactor: move /payments into vue component#3414
dni merged 3 commits intodevfrom
refactor/page-component

Conversation

@dni
Copy link
Copy Markdown
Member

@dni dni commented Oct 16, 2025

first step as an attempt to decouple the frontend more from the backend. as talked with @talvasconcelos. this gets rid of the DynamicComponent loading of the payments page because there is nothing that has to be rendered on the server side for it to work.

  • create generic empty route with just base.html for reloads
  • move into /static/js/pages / static/templates/pages

@dni dni requested a review from talvasconcelos October 16, 2025 07:09
@codecov
Copy link
Copy Markdown

codecov Bot commented Oct 16, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 55.84%. Comparing base (2856803) to head (af11549).
⚠️ Report is 1 commits behind head on dev.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #3414   +/-   ##
=======================================
  Coverage   55.84%   55.84%           
=======================================
  Files         116      116           
  Lines       15304    15304           
=======================================
+ Hits         8546     8547    +1     
+ Misses       6758     6757    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dni dni marked this pull request as ready for review October 16, 2025 07:24
@dni dni added this to the 1.3.1 milestone Oct 16, 2025
@arcbtc
Copy link
Copy Markdown
Member

arcbtc commented Oct 16, 2025

Wont this get bloaty rather than dynamically loading, adding all the components to package.json?

@dni
Copy link
Copy Markdown
Member Author

dni commented Oct 17, 2025

Wont this get bloaty rather than dynamically loading, adding all the components to package.json?

this improves the speed noticeable for all users, and its only a couple of pages currently. the first page load will be minutly slower but the navigation around the site will be faster because it saves 1 ajax call for the html on each navigation.

in the future the quasar app could have a build step and those components and templates can get lazy loaded, but for now this is just a cleanup that get us into that direction step by step. then we have both speed in the ui + speed on the first load.

@dni dni modified the milestones: 1.3.1, 1.3.2 Oct 17, 2025
@motorina0 motorina0 modified the milestones: 1.3.2, 1.4.0 Oct 21, 2025
Comment thread lnbits/templates/base.html
dni added 3 commits October 30, 2025 13:23
- remove generic route
- move into /static/js/pages / static/templates/pages
@dni dni force-pushed the refactor/page-component branch from e640a7f to af11549 Compare October 30, 2025 12:24
@dni dni modified the milestones: 1.4.0, 1.3.2 Oct 30, 2025
@dni dni requested a review from talvasconcelos October 30, 2025 15:31
@dni dni merged commit dd27b19 into dev Oct 31, 2025
44 checks passed
@dni dni deleted the refactor/page-component branch October 31, 2025 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants