Skip to content

Replaced admin > settings page horizontal header nav with drop down nav#3456

Closed
blackcoffeexbt wants to merge 1 commit intolnbits:devfrom
blackcoffeexbt:feat/mobile-settings-menu
Closed

Replaced admin > settings page horizontal header nav with drop down nav#3456
blackcoffeexbt wants to merge 1 commit intolnbits:devfrom
blackcoffeexbt:feat/mobile-settings-menu

Conversation

@blackcoffeexbt
Copy link
Copy Markdown
Collaborator

Replaced admin /settings page horizontal header nav with drop down navigation:

The abbreviated section titles are confusing. Drop down nav is easier to use.

Before:
image

After:
image

image

@codecov
Copy link
Copy Markdown

codecov Bot commented Oct 29, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 55.82%. Comparing base (248fcc0) to head (f7a83b2).
⚠️ Report is 20 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #3456      +/-   ##
==========================================
- Coverage   55.84%   55.82%   -0.02%     
==========================================
  Files         116      116              
  Lines       15304    15304              
==========================================
- Hits         8546     8544       -2     
- Misses       6758     6760       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Collaborator

@motorina0 motorina0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread lnbits/core/templates/admin/index.html Outdated
{ value: 'extensions', label: $t('extensions') },
{ value: 'notifications', label: $t('notifications') },
{ value: 'audit', label: $t('audit') },
{ value: 'library', label: $t('library') },
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i dont think this language label exist

@blackcoffeexbt blackcoffeexbt force-pushed the feat/mobile-settings-menu branch from 489baef to f7a83b2 Compare October 29, 2025 13:36
@motorina0
Copy link
Copy Markdown
Collaborator

Changes migrated too #3496
(rebase effort too high)

@motorina0 motorina0 closed this Nov 10, 2025
motorina0 added a commit that referenced this pull request Nov 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants