Skip to content

fix: handle all lnurl exceptions on lnurlscan endpoint#3451

Merged
dni merged 1 commit intodevfrom
fix/lnurlscan-exceptions
Oct 30, 2025
Merged

fix: handle all lnurl exceptions on lnurlscan endpoint#3451
dni merged 1 commit intodevfrom
fix/lnurlscan-exceptions

Conversation

@dni
Copy link
Copy Markdown
Member

@dni dni commented Oct 27, 2025

related to #3448 but now an uppercase lnaddress still throws an error.

screenshot-1761560474

@dni dni added this to the 1.3.2 milestone Oct 27, 2025
@codecov
Copy link
Copy Markdown

codecov Bot commented Oct 27, 2025

Codecov Report

❌ Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 55.84%. Comparing base (f794373) to head (2fdf419).
⚠️ Report is 6 commits behind head on dev.

Files with missing lines Patch % Lines
lnbits/core/views/lnurl_api.py 80.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #3451   +/-   ##
=======================================
  Coverage   55.84%   55.84%           
=======================================
  Files         116      116           
  Lines       15304    15304           
=======================================
  Hits         8546     8546           
  Misses       6758     6758           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dni dni merged commit 2856803 into dev Oct 30, 2025
44 checks passed
@dni dni deleted the fix/lnurlscan-exceptions branch October 30, 2025 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants