Skip to content

refactor: lndgrpc, update grpcs file, use types and enums, LookupInvoiceV2#3469

Merged
dni merged 2 commits intodevfrom
fix/lndgrpc
Nov 10, 2025
Merged

refactor: lndgrpc, update grpcs file, use types and enums, LookupInvoiceV2#3469
dni merged 2 commits intodevfrom
fix/lndgrpc

Conversation

@dni
Copy link
Copy Markdown
Member

@dni dni commented Nov 1, 2025

we can use the track payment v2 top level fees and preimage instead of the htlc's

https://lightning.engineering/api-docs/api/lnd/router/track-payment-v2/#lnrpcpayment

inspiration taken from here: 2343878

  • added script to update grpcs files
  • removed type ignore
  • update grpc files
  • LookupInvoiceV2

@codecov
Copy link
Copy Markdown

codecov Bot commented Nov 1, 2025

Codecov Report

❌ Patch coverage is 59.25926% with 44 lines in your changes missing coverage. Please review.
✅ Project coverage is 55.64%. Comparing base (dd27b19) to head (68e53a0).
⚠️ Report is 23 commits behind head on dev.

Files with missing lines Patch % Lines
lnbits/wallets/lndgrpc.py 70.27% 22 Missing ⚠️
lnbits/wallets/lnd_grpc_files/router_pb2.py 6.66% 14 Missing ⚠️
...nbits/wallets/lnd_grpc_files/lightning_pb2_grpc.py 55.55% 4 Missing ⚠️
lnbits/wallets/lnd_grpc_files/router_pb2_grpc.py 55.55% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #3469      +/-   ##
==========================================
- Coverage   55.82%   55.64%   -0.19%     
==========================================
  Files         116      116              
  Lines       15304    15343      +39     
==========================================
- Hits         8544     8538       -6     
- Misses       6760     6805      +45     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dni dni changed the title refactor: lndgrpc status enum and toplevel fees/preimage fix: lndgrpc status enum and toplevel fees/preimage update grpcs files Nov 1, 2025
@dni dni changed the title fix: lndgrpc status enum and toplevel fees/preimage update grpcs files refactor: lndgrpc, update grpcs file, use types and enums Nov 1, 2025
@dni dni changed the title refactor: lndgrpc, update grpcs file, use types and enums refactor: lndgrpc, update grpcs file, use types and enums, LookupInvoiceV2 Nov 1, 2025
dni added 2 commits November 3, 2025 08:17
…iceV2

more verbose logging of status

typo

add update grpc script

update grpc files

remove ignores

fix imports

imports and enums

clean clean clean

rename fixtures

fixtures add fees

fix calls

more fuixtures

fixup type

dumb error :D

remove inflight update
@dni dni added this to the 1.3.2 milestone Nov 3, 2025
Comment thread tests/wallets/fixtures/json/fixtures_rpc.json
@dni dni merged commit 691b7ad into dev Nov 10, 2025
44 checks passed
@dni dni deleted the fix/lndgrpc branch November 10, 2025 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants