Skip to content

refactor: simplify base.js#3473

Merged
dni merged 3 commits intodevfrom
refactor/base-api-js
Nov 4, 2025
Merged

refactor: simplify base.js#3473
dni merged 3 commits intodevfrom
refactor/base-api-js

Conversation

@dni
Copy link
Copy Markdown
Member

@dni dni commented Nov 3, 2025

  • api / windowMixin / utils each its file
  • added globals.js and moved bits from base.html

dni added 2 commits November 3, 2025 14:30
- api / windowMixin / utils each its file
- added globals.js and moved bits from base.html
@dni dni force-pushed the refactor/base-api-js branch from e336084 to 3c4f25e Compare November 3, 2025 13:39
@codecov
Copy link
Copy Markdown

codecov Bot commented Nov 3, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 55.84%. Comparing base (877af0c) to head (c978e27).
⚠️ Report is 2 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #3473      +/-   ##
==========================================
+ Coverage   55.82%   55.84%   +0.01%     
==========================================
  Files         116      116              
  Lines       15304    15304              
==========================================
+ Hits         8544     8546       +2     
+ Misses       6760     6758       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Collaborator

@talvasconcelos talvasconcelos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested

@dni dni requested a review from motorina0 November 4, 2025 07:04
Comment thread lnbits/static/js/base.js Outdated
Comment thread lnbits/static/js/utils.js Outdated
Comment thread lnbits/static/js/lnurl.js
Comment thread lnbits/static/js/api.js Outdated
@dni dni merged commit d142d76 into dev Nov 4, 2025
44 checks passed
@dni dni deleted the refactor/base-api-js branch November 4, 2025 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants