Skip to content

fix: vertically center first install#3501

Merged
dni merged 2 commits intodevfrom
fix/first_install
Nov 11, 2025
Merged

fix: vertically center first install#3501
dni merged 2 commits intodevfrom
fix/first_install

Conversation

@talvasconcelos
Copy link
Copy Markdown
Collaborator

@talvasconcelos talvasconcelos commented Nov 10, 2025

main html tag (<main></main>) needs "centering"

Style is applied on the template and scoped... so it doesn't affect other tags!

image

Closes #3497

@codecov
Copy link
Copy Markdown

codecov Bot commented Nov 10, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 56.11%. Comparing base (b4eccb9) to head (a222738).
⚠️ Report is 3 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #3501      +/-   ##
==========================================
+ Coverage   56.10%   56.11%   +0.01%     
==========================================
  Files         117      117              
  Lines       15688    15704      +16     
==========================================
+ Hits         8801     8812      +11     
- Misses       6887     6892       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@talvasconcelos
Copy link
Copy Markdown
Collaborator Author

talvasconcelos commented Nov 10, 2025

IMHO, this is a one time page, it's fine to have the style tag with the styling... I can change it if needed! @dni @motorina0

Comment thread lnbits/templates/pages/first-install.vue Outdated
@dni dni self-requested a review November 10, 2025 18:11
@dni dni merged commit 0ec8139 into dev Nov 11, 2025
44 checks passed
@dni dni deleted the fix/first_install branch November 11, 2025 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] vertically center first_install form

3 participants