refactor: lnbits-wallet-charts and clean up paymentFiltering#3526
Merged
Conversation
bdc22c2 to
bc2a827
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #3526 +/- ##
=======================================
Coverage 56.13% 56.13%
=======================================
Files 121 121
Lines 15816 15816
=======================================
Hits 8878 8878
Misses 6938 6938 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
21a7ccc to
7e710fb
Compare
lnbits-wallet-charts and clean up paymentFiltering
7e710fb to
85fe0a5
Compare
e711d94 to
40bba4c
Compare
40bba4c to
69fa6f8
Compare
- debounce rendering of charts. fixes isses if filter is changed too fast and the chart rendering runs into itself destroying and creating thechart at the same time. - pass paymentFilter prop to payment-list and use it - pass paymentFilter prop to charts and use it - optional filter argument for utils.js prepareFilter - fixes unhandled cases ins handleFilterChanged() in payment-list fix log
69fa6f8 to
0b85c36
Compare
motorina0
reviewed
Nov 20, 2025
0b85c36 to
2fa0351
Compare
2fa0351 to
a4c45fb
Compare
motorina0
approved these changes
Nov 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
handleFilterChanged()in payment-list