feat: move wallet.html to vue component. FINAL DynamicComponent pr#3559
Merged
feat: move wallet.html to vue component. FINAL DynamicComponent pr#3559
wallet.html to vue component. FINAL DynamicComponent pr#3559Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #3559 +/- ##
==========================================
- Coverage 56.47% 56.46% -0.02%
==========================================
Files 121 121
Lines 15873 15856 -17
==========================================
- Hits 8965 8953 -12
+ Misses 6908 6903 -5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
talvasconcelos
approved these changes
Nov 24, 2025
motorina0
reviewed
Nov 24, 2025
| ): | ||
| if wal: | ||
| wallet = await get_wallet(wal.hex) | ||
| elif len(user.wallets) == 0: |
Collaborator
There was a problem hiding this comment.
This check is still important. An user should ALWAYS have at least one wallet.
Member
Author
There was a problem hiding this comment.
how about we always create 1 wallet when creating an user and an user can only delete his last wallet when he deletes his account?
Member
Author
There was a problem hiding this comment.
a wallet is already created within the create_user_account service and with this would that be good? #3564
motorina0
approved these changes
Nov 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this is the last of the extensive frontend refactoring getting rid of
Dynamic Componentdifference in generic /wallet api.
g.user.wallets