feat: Improvements to settings > routing fee reserve settings UX #3857
feat: Improvements to settings > routing fee reserve settings UX #3857arcbtc merged 6 commits intolnbits:devfrom
Conversation
7ce5934 to
f2bbed4
Compare
|
Lint fails. |
| opacity: 0.4; | ||
| } | ||
|
|
||
| .q-tooltip { |
There was a problem hiding this comment.
do not override default quasar classes, there most likely is a variable to change for this. and it can have unexpected consequences in other unintended places.
There was a problem hiding this comment.
The tooltip font size is defined here in Quasar - https://github.com/quasarframework/quasar/blob/20201fb14e9e2dcbd352c6e055ba45f172d4a0f6/ui/src/components/tooltip/QTooltip.sass#L1
This can't be set as a var from LNbits so has to be set in base.scss. The tooltip size defined in Quasar is 10px which is far too small. A 14px minimum font size is recommended for interaction-heavy pages.
Should this tooltip text size increase be a standalone PR?
https://www.learnui.design/blog/mobile-desktop-website-font-size-guidelines.html#text-vs-interaction
b6e02b2 to
f81f132
Compare
… better field labels and tooltips Added desc comment to i18n-ai-tool
…TS_FUNDING_SOURCE_PAY_INVOICE_WAIT_SECONDS example
…blackcoffeexbt/lnbits into feature/fee_reserve_settings_ux
f81f132 to
79d9c36
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #3857 +/- ##
==========================================
- Coverage 56.44% 56.44% -0.01%
==========================================
Files 123 123
Lines 16943 16944 +1
==========================================
Hits 9564 9564
- Misses 7379 7380 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Improved UX of the settings > routing fee reserve settings to help users understand how these settings work.
I'll run the i18n on the non en languages when this PR is approved.