Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #3927 +/- ##
==========================================
+ Coverage 56.72% 63.02% +6.30%
==========================================
Files 124 124
Lines 16990 17019 +29
==========================================
+ Hits 9638 10727 +1089
+ Misses 7352 6292 -1060 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
motorina0
approved these changes
Apr 14, 2026
dni
reviewed
Apr 15, 2026
| auth_https_only: bool = Field(default=True) | ||
| # Keep disabled by default so local HTTP installs continue to work unless | ||
| # operators explicitly opt into HTTPS-only auth cookies. | ||
| auth_https_only: bool = Field(default=False) |
Member
There was a problem hiding this comment.
this will use insecure cookies when running behind a proxy basically on all production instances. we need to add it to the docs on how to run behind a proxy and what to configure. in my opionen the sane default is True and if you want to develop locally, you set it to false.
ai-chen2050
pushed a commit
to loka-network/agents-pay-service
that referenced
this pull request
Apr 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I get the logic in the initial change, but default behavior should continue as it was