Switch to DistributedSampler#105
Merged
sfc-gh-sbekman merged 15 commits intomainfrom Mar 25, 2025
Merged
Conversation
Co-authored-by: Stas Bekman <[email protected]>
Co-authored-by: Stas Bekman <[email protected]>
Co-authored-by: Stas Bekman <[email protected]>
sfc-gh-sbekman
approved these changes
Mar 25, 2025
Collaborator
sfc-gh-sbekman
left a comment
There was a problem hiding this comment.
I suggest to merge and then I will test as it looks it'll take me quite some time to deal with all the other changes as I haven't rebased in a while.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously we were pre-sharding loading datasets and saving to a cache file for each process. However, this is more cumbersome and error-prone than loading/processing data with a single process and using the DistributedSampler. Switching to use the DistributedSampler in this PR, which simplifies data loading and makes it more readable.
Other changes: