Fix for cache path arg included values#111
Merged
sfc-gh-sbekman merged 2 commits intomainfrom Mar 25, 2025
Merged
Conversation
sfc-gh-sbekman
approved these changes
Mar 25, 2025
Collaborator
sfc-gh-sbekman
left a comment
There was a problem hiding this comment.
Thank you for the quick fix, Mike
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With the move to using distributed sampler, we want each rank to calculate the same cache path for a given data source. However a recent change in #102 that changed
local_rank,global_rank, andworld_sizeto being Pydantic computed_fields meant that these values were being included in the args that determine the cache path for a given data source. Reverting these changes and making those fields withexclude=Trueso they do not pollute the cache path args.