Human friendly values for DeepSpeed config#167
Merged
sfc-gh-mwyatt merged 4 commits intomainfrom May 8, 2025
Merged
Conversation
sfc-gh-sbekman
approved these changes
May 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Followup to #166 that extends human-friendly numerical parsing functionality to DeepSpeed configs. Since the DeepSpeed config is defined in that library we cannot use
HumanIntandHumanFloatas types to automatically handle parsing. Instead we must do a try...except with each field passed by the user in the config dict. TheHumanIntandHumanFloatshould likely be added to DeepSpeed. Will follow up in the future with a PR over there.Resolves #165