fix(store): preserve underscores in BM25 search terms#404
Merged
Conversation
sanitizeFTS5Term stripped all non-letter/non-number characters including underscores, causing snake_case identifiers like `my_variable` to become `myvariable` and silently fail BM25 matches. Add underscore to the preserved character set in the Unicode regex. Export the function and add unit tests covering snake_case, contractions, punctuation stripping, and unicode. Fixes tobi#305 Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>
fxstein
pushed a commit
to fxstein/qmd
that referenced
this pull request
Mar 18, 2026
Preserve hyphens and underscores in sanitizeFTS5Term so FTS5's unicode61 tokenizer can split them symmetrically at query time, producing precise phrase matches. Also fix validateSemanticQuery false positive that rejected hyphenated terms like DEC-0054 as negation syntax in vec/hyde queries. Complements tobi#404 (underscore-only fix) by also covering hyphens. Refs: tobi#305, tobi#417
zeattacker
pushed a commit
to zeattacker/qmd
that referenced
this pull request
Mar 26, 2026
Preserve hyphens and underscores in sanitizeFTS5Term so FTS5's unicode61 tokenizer can split them symmetrically at query time, producing precise phrase matches. Also fix validateSemanticQuery false positive that rejected hyphenated terms like DEC-0054 as negation syntax in vec/hyde queries. Complements tobi#404 (underscore-only fix) by also covering hyphens. Refs: tobi#305, tobi#417
sangdo90
pushed a commit
to sangdo90/qmd
that referenced
this pull request
Apr 5, 2026
Preserve hyphens and underscores in sanitizeFTS5Term so FTS5's unicode61 tokenizer can split them symmetrically at query time, producing precise phrase matches. Also fix validateSemanticQuery false positive that rejected hyphenated terms like DEC-0054 as negation syntax in vec/hyde queries. Complements tobi#404 (underscore-only fix) by also covering hyphens. Refs: tobi#305, tobi#417
Contributor
Author
|
Thanks for the quick merge! |
tanarchytan
referenced
this pull request
in tanarchytan/lotl
Apr 8, 2026
sanitizeFTS5Term stripped all non-letter/non-number characters including underscores, causing snake_case identifiers like `my_variable` to become `myvariable` and silently fail BM25 matches. Add underscore to the preserved character set in the Unicode regex. Export the function and add unit tests covering snake_case, contractions, punctuation stripping, and unicode. Fixes #305 Co-authored-by: Matt Van Horn <[email protected]> Co-authored-by: Claude Opus 4.6 (1M context) <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #305
Summary
sanitizeFTS5Termstripped underscores from search terms, causing BM25 searches for snake_case identifiers to silently fail.my_variablebecamemyvariable, matching nothing.Changes
_to the preserved character set insanitizeFTS5Termregex (store.ts)Before / After
The CLI's copy of
sanitizeFTS5Term(cli/qmd.ts:1695) already uses\wwhich preserves underscores - this aligns the store's version.This contribution was developed with AI assistance (Claude Code).