fix: api keys are stored in plaintext within server in server.json#2532
Open
orbisai0security wants to merge 1 commit intoupstash:masterfrom
Open
Conversation
Automated security fix generated by Orbis Security AI
Code reviewFound 1 issue:
Lines 26 to 32 in 3f288be (Additionally, the PR’s proposed change itself is here: Lines 174 to 176 in 3f288be 🤖 Generated with Claude Code - If this code review was useful, please react with 👍. Otherwise, react with 👎. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix critical severity security issue in
server.json.Vulnerability
V-001server.json:28Description: API keys are stored in plaintext within server.json at three separate locations (lines 28, 45, and 59). This configuration file is a standard JSON file with no encryption or access control enforced at the application level. If server.json is accidentally committed to a version control system (e.g., Git), shared on a multi-user system without restrictive file permissions, or included in a build artifact, the API keys become immediately accessible to any party who obtains the file. The CLI setup command at packages/cli/src/commands/setup.ts:100 fetches API keys from the dashboard API and likely writes them to this file.
Changes
.gitignoreVerification
Automated security fix by OrbisAI Security