From 696d2969a36fac75161e318a273d176f68aff7c1 Mon Sep 17 00:00:00 2001 From: Nathaniel Caza Date: Mon, 5 Jan 2026 15:48:48 -0600 Subject: [PATCH] sort keys in Settings.Keys() method for consistent order Signed-off-by: Nathaniel Caza --- pkg/apis/clickhouse.altinity.com/v1/type_settings.go | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/pkg/apis/clickhouse.altinity.com/v1/type_settings.go b/pkg/apis/clickhouse.altinity.com/v1/type_settings.go index 0a3addd51..d30587887 100644 --- a/pkg/apis/clickhouse.altinity.com/v1/type_settings.go +++ b/pkg/apis/clickhouse.altinity.com/v1/type_settings.go @@ -300,11 +300,15 @@ func (s *Settings) SetScalarsFromMap(m map[string]string) *Settings { return s } -// Keys gets keys of the settings +// Keys gets keys of the settings in alphabetical order func (s *Settings) Keys() (keys []string) { s.WalkKeys(func(key string, setting *Setting) { keys = append(keys, key) }) + + // Sort keys to ensure deterministic ordering for Kubernetes manifest stability. + // Consistent ordering prevents unnecessary resource updates during reconciliation. + sort.Strings(keys) return keys }