Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: gatsbyjs/gatsby
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: alexmacarthur/gatsby
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 1 commit
  • 1 file changed
  • 1 contributor

Commits on Jan 20, 2018

  1. Remove call to delete page when path is modified. 

    When running the `gatsby-plugin-remove-trailing-slashes` plugin in development mode, whenever I made a change to a page, an infinite loop would be caused. It appeared as if `deletePage()` and/or `createPage()` were triggering the 'onCreatePage()` over and over. 

After simply removing the call to first delete the old page, this looping issue was resolved. 

This change also seems to be more consistent with the example in the documentation on how to set a custom layout, which does not include a call to delete the old page after modifying it. 

https://www.gatsbyjs.org/docs/creating-and-modifying-pages/
    @alexmacarthur
    alexmacarthur authored Jan 20, 2018
    Configuration menu
    Copy the full SHA
    09f32c4 View commit details
    Browse the repository at this point in the history
Loading