Summary
PSScriptAnalyzer hasn't been updated recently, and should be bumped.
Also, fwiw, the pslint sanity test obscures a failure I was having because of it's error handling. I think we should probably make this change as well:
diff --git a/test/lib/ansible_test/_internal/commands/sanity/pslint.py b/test/lib/ansible_test/_internal/commands/sanity/pslint.py
index f0082b55e7..0aab47f1d0 100644
--- a/test/lib/ansible_test/_internal/commands/sanity/pslint.py
+++ b/test/lib/ansible_test/_internal/commands/sanity/pslint.py
@@ -79,13 +79,8 @@ class PslintTest(SanityVersionNeutral):
stdout = ''
for cmd in cmds:
- try:
- stdout, stderr = run_command(args, cmd, env=env, capture=True)
- status = 0
- except SubprocessError as ex:
- stdout = ex.stdout
- stderr = ex.stderr
- status = ex.status
+ stdout, stderr = run_command(args, cmd, env=env, capture=True)
+ status = 0
if stderr:
raise SubprocessError(cmd=cmd, status=status, stderr=stderr, stdout=stdout)Issue Type
Feature Idea
Component Name
test/lib/ansible_test/_data/requirements/sanity.pslint.ps1
Additional Information
Code of Conduct
Summary
PSScriptAnalyzerhasn't been updated recently, and should be bumped.Also, fwiw, the pslint sanity test obscures a failure I was having because of it's error handling. I think we should probably make this change as well:
Issue Type
Feature Idea
Component Name
test/lib/ansible_test/_data/requirements/sanity.pslint.ps1
Additional Information
Code of Conduct