-
-
Notifications
You must be signed in to change notification settings - Fork 410
Permalink
Choose a base ref
{{ refName }}
default
Choose a head ref
{{ refName }}
default
Checking mergeability…
Don’t worry, you can still create the pull request.
Comparing changes
Choose two branches to see what’s changed or to start a new pull request.
If you need to, you can also or
learn more about diff comparisons.
Open a pull request
Create a new pull request by comparing changes across two branches. If you need to, you can also .
Learn more about diff comparisons here.
base repository: dominikh/go-tools
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}
default
Loading
...
head repository: dominikh/go-tools
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: alias
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}
default
Loading
- 14 commits
- 64 files changed
- 1 contributor
Commits on Mar 23, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 28477e6 - Browse repository at this point
Copy the full SHA 28477e6View commit details
Commits on Apr 20, 2024
-
Configuration menu - View commit details
-
Copy full SHA for aef147e - Browse repository at this point
Copy the full SHA aef147eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 985c675 - Browse repository at this point
Copy the full SHA 985c675View commit details
Commits on Apr 24, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 301cc85 - Browse repository at this point
Copy the full SHA 301cc85View commit details -
lintcmd/runner: include GODEBUG in cache key
GODEBUG can affect how we type-check code, due to the gotypesalias setting.
Configuration menu - View commit details
-
Copy full SHA for c8a3be3 - Browse repository at this point
Copy the full SHA c8a3be3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 30b5cb5 - Browse repository at this point
Copy the full SHA 30b5cb5View commit details -
Configuration menu - View commit details
-
Copy full SHA for f48d2a1 - Browse repository at this point
Copy the full SHA f48d2a1View commit details -
go/ir: don't check for duplicate function names in tests
Generic functions can instantiate generic types with type parameters, which can lead to methods with duplicated names. We handle this by using a generic-specific synthetic constant. However, we also generate wrappers for these instantiated methods, which leads to more duplicated names, and the code doesn't easily let us figure out that the wrapper is for an instantiated method. Instead of working around this further, remove the test for unique function names. Function names weren't unique in practice, anyway, because of test variants of packages.
Configuration menu - View commit details
-
Copy full SHA for a5e345c - Browse repository at this point
Copy the full SHA a5e345cView commit details -
go/ir: remove statistics collection from test
We've never cared about these statistics when running the test. Now it is much simpler to tell what the test is actually testing: that building the IR form of all packages in stdlib doesn't panic.
Configuration menu - View commit details
-
Copy full SHA for 07880ba - Browse repository at this point
Copy the full SHA 07880baView commit details -
Configuration menu - View commit details
-
Copy full SHA for 53a20a1 - Browse repository at this point
Copy the full SHA 53a20a1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4c40d00 - Browse repository at this point
Copy the full SHA 4c40d00View commit details -
Update all checks to support explicit alias nodes in the type graph
Go 1.22 introduced go/types.Alias, a node that explicitly encodes type aliases. GODEBUG=gotypesalias=1 enables this behavior. In Go 1.23, that setting will become the new default. Update all code that compares types (via equality, string equality, or type assertions) to account for aliases. Most checks don't require changes, as they operate on underlying types. For the remainder, a mix of types.Unalias and explicit handling of aliases is necessary. Closes: gh-1523
Configuration menu - View commit details
-
Copy full SHA for 9df349e - Browse repository at this point
Copy the full SHA 9df349eView commit details -
Configuration menu - View commit details
-
Copy full SHA for fc7b052 - Browse repository at this point
Copy the full SHA fc7b052View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4295b6a - Browse repository at this point
Copy the full SHA 4295b6aView commit details
Loading
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff master...alias