Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: dominikh/go-tools
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: dominikh/go-tools
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: alias
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 14 commits
  • 64 files changed
  • 1 contributor

Commits on Mar 23, 2024

  1. Update CI pipeline

    dominikh committed Mar 23, 2024
    Configuration menu
    Copy the full SHA
    28477e6 View commit details
    Browse the repository at this point in the history

Commits on Apr 20, 2024

  1. Configuration menu
    Copy the full SHA
    aef147e View commit details
    Browse the repository at this point in the history
  2. Remove support for Go 1.21

    dominikh committed Apr 20, 2024
    Configuration menu
    Copy the full SHA
    985c675 View commit details
    Browse the repository at this point in the history

Commits on Apr 24, 2024

  1. Configuration menu
    Copy the full SHA
    301cc85 View commit details
    Browse the repository at this point in the history
  2. lintcmd/runner: include GODEBUG in cache key

    GODEBUG can affect how we type-check code, due to the gotypesalias
    setting.
    dominikh committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    c8a3be3 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    30b5cb5 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    f48d2a1 View commit details
    Browse the repository at this point in the history
  5. go/ir: don't check for duplicate function names in tests

    Generic functions can instantiate generic types with type parameters,
    which can lead to methods with duplicated names. We handle this by using
    a generic-specific synthetic constant. However, we also generate
    wrappers for these instantiated methods, which leads to more duplicated
    names, and the code doesn't easily let us figure out that the wrapper is
    for an instantiated method. Instead of working around this further,
    remove the test for unique function names. Function names weren't unique
    in practice, anyway, because of test variants of packages.
    dominikh committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    a5e345c View commit details
    Browse the repository at this point in the history
  6. go/ir: remove statistics collection from test

    We've never cared about these statistics when running the test. Now it
    is much simpler to tell what the test is actually testing: that building
    the IR form of all packages in stdlib doesn't panic.
    dominikh committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    07880ba View commit details
    Browse the repository at this point in the history
  7. ci: run tests on Go tip

    dominikh committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    53a20a1 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    4c40d00 View commit details
    Browse the repository at this point in the history
  9. Update all checks to support explicit alias nodes in the type graph

    Go 1.22 introduced go/types.Alias, a node that explicitly encodes type
    aliases. GODEBUG=gotypesalias=1 enables this behavior. In Go 1.23, that
    setting will become the new default.
    
    Update all code that compares types (via equality, string equality, or
    type assertions) to account for aliases. Most checks don't require
    changes, as they operate on underlying types. For the remainder, a mix
    of types.Unalias and explicit handling of aliases is necessary.
    
    Closes: gh-1523
    dominikh committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    9df349e View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    fc7b052 View commit details
    Browse the repository at this point in the history
  11. WIP

    dominikh committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    4295b6a View commit details
    Browse the repository at this point in the history
Loading