Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: sasbury/mini
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: frou/mini
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 2 commits
  • 2 files changed
  • 1 contributor

Commits on Dec 23, 2016

  1. Add Options and DefaultOptions:

    The first and currently only option controls whether string values are assumed to be escaped (using Go escaping syntax). This defaults to true for backwards compatibility. New 'constructors' have been added for type Config for when options are used.
    
    The behaviour (which existed before I introduced Options) where, if a string value contains an invalid escape sequence, the specified default value is returned, seems a bit suspect. It might be better to surface some kind of error to the package consumer so that they are made aware that there is an invalid escape sequence in their INI that needs fixed.
    
    Similarly, the behaviour around keys with no value (e.g. 'foo=' and 'foo[]=') might need to be assessed. Should that yield an error, the empty string, or the specified default value(*)? When the key with no value is part of a string array, should that cause an error, cause an empty string to be part of the yielded slice, or cause the yielded slice to have one fewer elements(*)? The behaviour as of this commit is marked with (*).
    Duncan Holm committed Dec 23, 2016
    Configuration menu
    Copy the full SHA
    78537d8 View commit details
    Browse the repository at this point in the history

Commits on Apr 8, 2017

  1. Merge branch 'ctor-options'

    Duncan Holm committed Apr 8, 2017
    Configuration menu
    Copy the full SHA
    931b187 View commit details
    Browse the repository at this point in the history
Loading