Replies: 2 comments 7 replies
-
|
@jonkoops FIY |
Beta Was this translation helpful? Give feedback.
0 replies
-
|
I'm all for revamping the JS adapter, both in terms of how it is implemented/built, but also would like to see some improvements on its internals/APIs as well. Would probably make sense to start it as a completely new project (separate git repo), which will make it possible to break the API and change how it behaves without worrying about backwards compatiblity. |
Beta Was this translation helpful? Give feedback.
7 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
-
I came across this issue while working on a mobile app using Capacitor. The current implementation of keycloak-js is hard to extend and the code is probably also hard to maintain. For Capacitor there is an alternative implementation of keycloak-js: https://github.com/JohannesBauer97/keycloak-ionic because a lot of functions would need to be copied to. From this experience I started this and ported keycloak-js to typescript https://github.com/footageone/keycloak-js/tree/main/src
It's now modular and could also be release as an ESM version. It also includes the capacitor adapters. But actually I would suggest to create separate packages for every adapter, as each adapter has different requirements.
There is still a lot of work to improve the keycloak-js code make it up to date.
Beta Was this translation helpful? Give feedback.
All reactions