You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I have some ideas around this, but no definitive solution, so why not open a discussion:
1 Enable Features - actual behaviour:
At the moment, when you enable features, you only get log output for some features, not for all. The exact logic and logging can be found in Profile.java
The UX around this is kind of bad. For example for the "docker" feature, there's no log output at all if it's enabled, so you wouldn't know if it's really enabled by using the build command.
1.1 Enable Features - desired behaviour:
Always show which features will be enabled at next startup when invoking build --features=...,.... Also at startup, bc. these two steps might happen a long timespan apart (base image was built in CI, startup happens later on when this image went through other quality gates after it got pushed in a registry)
2 Disable Features - actual behaviour:
At the moment there is no log entry at all when a feature got disabled using build --features-disabled=...,....
2.1 Disable Features - desired behaviour:
When a feature got disabled using build, show an info log msg in the build step that it got disabled. Only show the log message at startup when it's one of the default features.
Alternative approach:
Alternatively, always show the full List of disabled and enabled features in the startup log (level debug?) and when any feature gets changed using build (as info log?) for immediate feedback about the results of the build, which atm only happens for preview features.
reacted with thumbs up emoji reacted with thumbs down emoji reacted with laugh emoji reacted with hooray emoji reacted with confused emoji reacted with heart emoji reacted with rocket emoji reacted with eyes emoji
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
-
I have some ideas around this, but no definitive solution, so why not open a discussion:
1 Enable Features - actual behaviour:
At the moment, when you enable features, you only get log output for some features, not for all. The exact logic and logging can be found in Profile.java
The UX around this is kind of bad. For example for the "docker" feature, there's no log output at all if it's enabled, so you wouldn't know if it's really enabled by using the
buildcommand.1.1 Enable Features - desired behaviour:
Always show which features will be enabled at next startup when invoking
build --features=...,.... Also at startup, bc. these two steps might happen a long timespan apart (base image was built in CI, startup happens later on when this image went through other quality gates after it got pushed in a registry)2 Disable Features - actual behaviour:
At the moment there is no log entry at all when a feature got disabled using
build --features-disabled=...,....2.1 Disable Features - desired behaviour:
When a feature got disabled using
build, show an info log msg in the build step that it got disabled. Only show the log message at startup when it's one of the default features.Alternative approach:
Alternatively, always show the full List of disabled and enabled features in the startup log (level debug?) and when any feature gets changed using
build(as info log?) for immediate feedback about the results of the build, which atm only happens for preview features.Beta Was this translation helpful? Give feedback.
All reactions