From 5dc8fda1145b724d9363a305f5e616963effa584 Mon Sep 17 00:00:00 2001 From: Will Li Date: Fri, 14 Mar 2025 21:57:41 +0000 Subject: [PATCH 1/3] Windows dump_crash_context take reference to crash_context --- src/windows/minidump_writer.rs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/windows/minidump_writer.rs b/src/windows/minidump_writer.rs index 21753689..a5b7bebd 100644 --- a/src/windows/minidump_writer.rs +++ b/src/windows/minidump_writer.rs @@ -130,7 +130,7 @@ impl MinidumpWriter { exception_code, }; - Self::dump_crash_context(cc, minidump_type, destination) + Self::dump_crash_context(&cc, minidump_type, destination) } } @@ -149,7 +149,7 @@ impl MinidumpWriter { /// is the responsibility of the caller to ensure that the pointer is valid /// for the duration of this function call. pub fn dump_crash_context( - crash_context: crash_context::CrashContext, + crash_context: &crash_context::CrashContext, minidump_type: Option, destination: &mut std::fs::File, ) -> Result<(), Error> { From f6d97c6a427aef50f2cc0217c1a581b2cb4ac81a Mon Sep 17 00:00:00 2001 From: Jake Shadle Date: Mon, 17 Mar 2025 10:35:51 +0100 Subject: [PATCH 2/3] Fix lint --- src/linux/dumper_cpu_info/x86_mips.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/linux/dumper_cpu_info/x86_mips.rs b/src/linux/dumper_cpu_info/x86_mips.rs index 025a97be..0999065e 100644 --- a/src/linux/dumper_cpu_info/x86_mips.rs +++ b/src/linux/dumper_cpu_info/x86_mips.rs @@ -111,7 +111,7 @@ pub fn write_cpu_information(sys_info: &mut MDRawSystemInfo) -> Result<()> { { sys_info.processor_level = cpu_info_table[3].value as u16; sys_info.processor_revision = - (cpu_info_table[1].value << 8 | cpu_info_table[2].value) as u16; + ((cpu_info_table[1].value << 8) | cpu_info_table[2].value) as u16; } if !vendor_id.is_empty() { let vendor_id = vendor_id.as_bytes(); From b3d6e98d10a2d8580253b0533808e2a5392313f7 Mon Sep 17 00:00:00 2001 From: Jake Shadle Date: Mon, 17 Mar 2025 10:36:22 +0100 Subject: [PATCH 3/3] Fix test --- tests/windows_minidump_writer.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/windows_minidump_writer.rs b/tests/windows_minidump_writer.rs index 1b2c1d4b..95f08467 100644 --- a/tests/windows_minidump_writer.rs +++ b/tests/windows_minidump_writer.rs @@ -164,7 +164,7 @@ fn dump_external_process() { // SAFETY: We keep the process we are dumping alive until the minidump is written // and the test process keep the pointers it sent us alive until it is killed - MinidumpWriter::dump_crash_context(crash_context, None, tmpfile.as_file_mut()) + MinidumpWriter::dump_crash_context(&crash_context, None, tmpfile.as_file_mut()) .expect("failed to write minidump"); child.kill().expect("failed to kill child");