Skip to content

Adding a file currently being written #332

@chrfle

Description

@chrfle

Hello

Is there any specific reason minizip does not allow adding files that are open in write mode?

I tracked it down to this line:
https://github.com/nmoinvaz/minizip/blob/master/mz_strm_os_win32.c#L75

Where it's explicitly stated that only files that are open read only are allowed to be added.

Changing it to FILE_SHARE_READ | FILE_SHARE_WRITE seems to solve it for my application. Would you mind such a change upstream?

Metadata

Metadata

Assignees

No one assigned

    Labels

    fixedIssue or bug has been fixed

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions