Conversation
| name: Bug Report | ||
| description: Report a bug in the system | ||
| title: "[Bug]: " | ||
| labels: ["bug"] |
There was a problem hiding this comment.
(As well for others)
Consider making a new label thats like 'triage' or similar and have it automatically added, so people are further reminded to assign topics.
|
@PawelPlesniak this should be ready for review. Desc is self explanatory Note that I purposely kept the scope very minimal, just changing the issue and PR template The more general github actions-like changes will come later, when I have time to investigate and implement :') |
There was a problem hiding this comment.
Uncomment and test
There was a problem hiding this comment.
Also tell kurt this exists! See if it can be included
- include in nightly generation integration test
- include drunc root in dunedaq db path (what what was discussed when talking about failure mode testing)
There was a problem hiding this comment.
Changes implemented. Note that I used the full path to call the sh file (./scripts/drunc_integtest_bundle.sh) instead of the pytest -m integration_tests, not sure if we wanted to support the pytest thing.
Description
A step in the right direction for #863
Updates the issue templates to highlight the fact that developers should label any new issues / PRs that they make.
Type of change
Suggested manual testing checklist
N/A
Developer checklist
Prior to marking this as "Ready for Review"
Tests ran on: N/A from release N/A
Unit tests - some tests can't be ran on the CI. This is documented. If this PR checks a feature that can't be tested with CI, this has been marked appropriately.
Integration tests - the
daqsystemtest_integtest_bundlerequires a lot of resources, and connections to the EHN1 infrastructure. Check the cross referenced list if you can't run these. The developer needs to run at least the .pytest --marker) passeddaqsystemtest_integtest_bundle.sh -k minimal_system_quick_test.pydaqsystemtest_integtest_bundle.shFinal checklist prior to marking this as "Ready for Review"
Reviewer checklist
druncare in the log filesdruncfailure appears:Once the features are validated and both the unit and integration tests pass, the PRs is ready to be merged.
Choose one of the following an complete all substepsPrior to merging
Once completed, the reviewer can merge the PR.
Notification message for a Slack channel
Note - this should be to #dunedaq-integration for general workflow that isn't during a release candidate period, and to #daq-release-prep otherwise.
For an single merge that changes the user workflow
For co-ordinated merge