Skip to content

Add global rich handler#884

Draft
emmuhamm wants to merge 2 commits intodevelopfrom
emmuhamm/global-rich-console
Draft

Add global rich handler#884
emmuhamm wants to merge 2 commits intodevelopfrom
emmuhamm/global-rich-console

Conversation

@emmuhamm
Copy link
Copy Markdown
Contributor

@emmuhamm emmuhamm commented Apr 21, 2026 •
edited
Loading

Description

Fixes #866

TO BE ADDEDD
WHAT DOES THIS PR CHANGE - ONE LINE.

DOCUMENT THE CHANGE BELOW OR DELETE IT

The relevant changes in the user workflow have been documented here (link URL)

Type of change

  • New feature / enhancement
  • Optimization
  • Bug fix
  • Breaking change
  • Documentation

List of required branches from other repositories

WHAT PRs NEED TO BE INCLUDED TO MAKE THE CHANGE.

Change log

WHAT HAS CHANGED.

Suggested manual testing checklist

LIST COMMANDS TO DEMONSTRATE CHANGE

Developer checklist

Prior to marking this as "Ready for Review"

Tests ran on: WHAT HOSTNAME from release RELEASE_NAME

Unit tests - some tests can't be ran on the CI. This is documented. If this PR checks a feature that can't be tested with CI, this has been marked appropriately.

Integration tests - the daqsystemtest_integtest_bundle requires a lot of resources, and connections to the EHN1 infrastructure. Check the cross referenced list if you can't run these. The developer needs to run at least the .

  • Unit tests (pytest --marker) passed
    • With relevant marker
    • Without marker
  • Integration tests passed
    • Only daqsystemtest_integtest_bundle.sh -k minimal_system_quick_test.py
    • Full daqsystemtest_integtest_bundle.sh
  • Testing skipped as there are no core code changes in this PR, this only relates to documentation/CI workflows

Final checklist prior to marking this as "Ready for Review"

  • Code is clearly commented.
  • New unit tests have been added, or is documented in # ISSUE NUMBER
  • A suitable reviewer has been chosen from this list.

Reviewer checklist
  • This branch has been rebased with develop prior to testing.
  • Suggested manual tests show changes.
  • CI workflows fails documented (if present)
  • Integration tests passed
    • Only concern yourself if failures related to drunc are in the log files
    • If non-drunc failure appears:
      • Validate failure in fresh working area
      • Contact Pawel if unsure

Once the features are validated and both the unit and integration tests pass, the PRs is ready to be merged.

Prior to merging

 Choose one of the following an complete all substeps
  • Changes only affect the Run Control, are in a single repository, and do not affect the end user.
    • Changes are documented in docstrings and code comments
    • Wiki has been updated if architectural or endpoint changes
  • Otherwise
    • Workflow changes demonstrated in the Change Log (if necessary)
    • Wiki has been updated (if necessary)
    • #daq-sw-librarians Slack channel notified (see below)

Once completed, the reviewer can merge the PR.

Notification message for a Slack channel

Note - this should be to #dunedaq-integration for general workflow that isn't during a release candidate period, and to #daq-release-prep otherwise.

For an single merge that changes the user workflow

The CCM WG has an isolated PR ready to merge that affects user workflows. The PR is:

_URL_

I will leave time for any comments, otherwise will merge these at the end of the work day _Insert your time zone_.

For co-ordinated merge

The CCM WG has a set of co-ordinated merges ready to merge. The PRs are:

_URL_

_URL_


I will leave time for any comments, otherwise will merge these at the end of the day.

@emmuhamm
Copy link
Copy Markdown
Contributor Author

emmuhamm commented Apr 21, 2026 •
edited
Loading

This needs testing, send help

((dbt) ) [emmuhamm@np04-srv-028 NFD_DEV_260422_A9]$ drunc-unified-shell ssh-standalone config/tests/nestedConfig.data.xml test-nested-config-failure-on-init pawel
[2026/04/22 08:22:27 UTC] ERROR      unified_shell.py:15                      drunc.unified_shell                                🔥🔥 
Exception thrown 🔥🔥
[2026/04/22 08:22:27 UTC] ERROR      unified_shell.py:16                      drunc.unified_shell                                
Unable to open database off of "oksconflibs:config/tests/nestedConfig.data.xml"; one reason is that it looks like 
"config/tests/nestedConfig.data.xml" doesn't exist
((dbt) ) [emmuhamm@np04-srv-028 NFD_DEV_260422_A9]$

@emmuhamm emmuhamm self-assigned this Apr 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@emmuhamm emmuhamm

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Feature]: Define a global rich.Console for the run control

2 participants

@emmuhamm @dunedaqbot