Skip to content

Fix FSM Logs#881

Open
emmuhamm wants to merge 1 commit intodevelopfrom
emmuhamm/fsm-logs
Open

Fix FSM Logs#881
emmuhamm wants to merge 1 commit intodevelopfrom
emmuhamm/fsm-logs

Conversation

@emmuhamm
Copy link
Copy Markdown
Contributor

@emmuhamm emmuhamm commented Apr 15, 2026 •
edited
Loading

Description

Fixes issue #880

Better logs in the FSM transitions

Now they show one of three things:


FSM command run: start for target root-controller with arguments {'run_number': 67, 'run_type': 'TEST', 'disable_data_storage': False, 'trigger_rate': 0.0, 'file_logbook_post': ''}

FSM command run: stop for target root-controller for run number 67

FSM command run: conf for target root-controller/df-controller/df-01

Type of change

  • New feature / enhancement

List of required branches from other repositories

N/A

Suggested manual testing checklist

Run drunc-unified-shell ssh-standalone config/daqsystemtest/example-configs.data.xml local-1x1-config emir-test start-run --run-number 1 wait 20 shutdown start-shell

See that the FSM commands are now logged in all the controllers. See that the arguments are put in the start command, and also that the run number is printed in the stop

Next, run boot and conf --target root-controller/df-controller

See that the target is properly logged in both the root controller and the df controller

Developer checklist

Prior to marking this as "Ready for Review"

Tests ran on: WHAT HOSTNAME from release RELEASE_NAME

Unit tests - some tests can't be ran on the CI. This is documented. If this PR checks a feature that can't be tested with CI, this has been marked appropriately.

Integration tests - the daqsystemtest_integtest_bundle requires a lot of resources, and connections to the EHN1 infrastructure. Check the cross referenced list if you can't run these. The developer needs to run at least the .

  • Unit tests (pytest --marker) passed
    • With relevant marker
    • Without marker
  • Integration tests passed
    • Only daqsystemtest_integtest_bundle.sh -k minimal_system_quick_test.py
    • Full daqsystemtest_integtest_bundle.sh
  • Testing skipped as there are no core code changes in this PR, this only relates to documentation/CI workflows

Final checklist prior to marking this as "Ready for Review"

  • Code is clearly commented.
  • New unit tests have been added, or is documented in # ISSUE NUMBER
  • A suitable reviewer has been chosen from this list.

Reviewer checklist
  • This branch has been rebased with develop prior to testing.
  • Suggested manual tests show changes.
  • CI workflows fails documented (if present)
  • Integration tests passed
    • Only concern yourself if failures related to drunc are in the log files
    • If non-drunc failure appears:
      • Validate failure in fresh working area
      • Contact Pawel if unsure

Once the features are validated and both the unit and integration tests pass, the PRs is ready to be merged.

Prior to merging

 Choose one of the following an complete all substeps
  • Changes only affect the Run Control, are in a single repository, and do not affect the end user.
    • Changes are documented in docstrings and code comments
    • Wiki has been updated if architectural or endpoint changes
  • Otherwise
    • Workflow changes demonstrated in the Change Log (if necessary)
    • Wiki has been updated (if necessary)
    • #daq-sw-librarians Slack channel notified (see below)

Once completed, the reviewer can merge the PR.

Notification message for a Slack channel

Note - this should be to #dunedaq-integration for general workflow that isn't during a release candidate period, and to #daq-release-prep otherwise.

For an single merge that changes the user workflow

The CCM WG has an isolated PR ready to merge that affects user workflows. The PR is:

_URL_

I will leave time for any comments, otherwise will merge these at the end of the work day _Insert your time zone_.

For co-ordinated merge

The CCM WG has a set of co-ordinated merges ready to merge. The PRs are:

_URL_

_URL_


I will leave time for any comments, otherwise will merge these at the end of the day.

@emmuhamm emmuhamm self-assigned this Apr 15, 2026
@emmuhamm emmuhamm linked an issue Apr 15, 2026 that may be closed by this pull request
[Feature]: Include FSM transitions in controller core log files, especially run numbers in root-controller logs #880
Open
@emmuhamm emmuhamm force-pushed the emmuhamm/fsm-logs branch from f7130cf to b3bbefb Compare April 29, 2026 09:45
@emmuhamm emmuhamm force-pushed the emmuhamm/fsm-logs branch from b3bbefb to 3b2016e Compare April 29, 2026 09:47
@emmuhamm emmuhamm requested a review from PawelPlesniak April 29, 2026 09:55
@emmuhamm emmuhamm marked this pull request as ready for review April 29, 2026 09:55
@emmuhamm
Copy link
Copy Markdown
Contributor Author

emmuhamm commented Apr 29, 2026

Hi @PawelPlesniak, this is now ready for review. As we've discussed, the logs show the run number and the targets. At the moment i am not logging the fact that -EAP and -EOASC have been called or not since we cant do that on the controller side.

When that gets fixed, I'll either fix this PR if its not merged in, or open a new one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@PawelPlesniak PawelPlesniak Awaiting requested review from PawelPlesniak

At least 1 approving review is required to merge this pull request.

Assignees

@emmuhamm emmuhamm

Labels

Controller Utilities

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Feature]: Include FSM transitions in controller core log files, especially run numbers in root-controller logs

2 participants

@emmuhamm @dunedaqbot