Add mypy settings and type hints for sessions manager#898
Open
Add mypy settings and type hints for sessions manager#898
Conversation
Contributor
Author
|
Just tagging more people to see if the mypy settings suggested by @PawelPlesniak in #828 and added here in |
Contributor
|
Hi @miruuna, thanks for this! When working with #862 for the utils, I defined the settings I used in this commit here: 2097249 It looks like we basically have near identical settings, except yours also includes Which I see no problems with. Also looks like your Ruff settings are comparable with what I used. So bottom line is, in my opinion I think thats enough since we've both used very similar settings. Interested to hear what other people think though |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes issue #850
Added
mypysettings inpyproject.tomlfound in #828.Added some return types but most of it was done already.
Type of change
List of required branches from other repositories
None
Change log
Added mypy settings
Suggested manual testing checklist
LIST COMMANDS TO DEMONSTRATE CHANGE
Run
mypy src/drunc/session_manager/Developer checklist
Prior to marking this as "Ready for Review"
Tests ran on:
NFD_DEV_260310_A9Unit tests - some tests can't be ran on the CI. This is documented. If this PR checks a feature that can't be tested with CI, this has been marked appropriately.
Integration tests - the
daqsystemtest_integtest_bundlerequires a lot of resources, and connections to the EHN1 infrastructure. Check the cross referenced list if you can't run these. The developer needs to run at least the .pytest --marker) passeddaqsystemtest_integtest_bundle.sh -k minimal_system_quick_test.pydaqsystemtest_integtest_bundle.shFinal checklist prior to marking this as "Ready for Review"
Reviewer checklist
druncare in the log filesdruncfailure appears:Once the features are validated and both the unit and integration tests pass, the PRs is ready to be merged.
Choose one of the following an complete all substepsPrior to merging
Once completed, the reviewer can merge the PR.
Notification message for a Slack channel
Note - this should be to #dunedaq-integration for general workflow that isn't during a release candidate period, and to #daq-release-prep otherwise.
For an single merge that changes the user workflow
For co-ordinated merge