Skip to content

Jamesturner246/modernise 1#554

Merged
jamesturner246 merged 21 commits intodevelopfrom
jamesturner246/modernise_1
Apr 28, 2026
Merged

Jamesturner246/modernise 1#554
jamesturner246 merged 21 commits intodevelopfrom
jamesturner246/modernise_1

Conversation

@jamesturner246
Copy link
Copy Markdown
Collaborator

@jamesturner246 jamesturner246 commented Apr 28, 2026

Description

Modernise, refresh and make compatible-ish with the DUNE-DAQ package workflow.

Fixes N/A

Type of change

  • Documentation (non-breaking change that adds or improves the documentation)
  • New feature (non-breaking change which adds functionality)
  • Optimization (non-breaking, back-end change that speeds up the code)
  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (whatever its nature)

Key checklist

  • All tests pass (eg. python -m pytest)
  • The documentation builds and looks OK (eg. python -m sphinx -b html docs docs/build)
  • Pre-commit hooks run successfully (eg. pre-commit run --all-files)

Further checks

  • Code is commented, particularly in hard-to-understand areas
  • Tests added or an issue has been opened to tackle that in the future. (Indicate issue here: # (issue))

PawelPlesniak
PawelPlesniak approved these changes Apr 28, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@PawelPlesniak PawelPlesniak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding a rubber stamp

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Apr 28, 2026 •
edited
Loading

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 0% with 111 lines in your changes missing coverage. Please review.
✅ Project coverage is 0.00%. Comparing base (a357a6b) to head (4234bfd).

Files with missing lines Patch % Lines
...c/drunc_ui/interfaces/process_manager_interface.py 0.00% 29 Missing ⚠️
src/drunc_ui/interfaces/controller_interface.py 0.00% 15 Missing ⚠️
src/drunc_ui/cli.py 0.00% 13 Missing ⚠️
src/drunc_ui/settings/settings.py 0.00% 9 Missing ⚠️
...runc_ui/main/management/commands/kafka_consumer.py 0.00% 6 Missing ⚠️
...c/drunc_ui/interfaces/session_manager_interface.py 0.00% 4 Missing ⚠️
src/drunc_ui/process_manager/views/partials.py 0.00% 4 Missing ⚠️
src/drunc_ui/controller/app_tree.py 0.00% 3 Missing ⚠️
...drunc_ui/main/management/commands/store_message.py 0.00% 3 Missing ⚠️
src/drunc_ui/main/views/partials.py 0.00% 3 Missing ⚠️
... and 14 more
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

❗ There is a different number of reports uploaded between BASE (a357a6b) and HEAD (4234bfd). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (a357a6b) HEAD (4234bfd)
2 1
Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #554       +/-   ##
===========================================
- Coverage    84.86%   0.00%   -84.87%     
===========================================
  Files           46      42        -4     
  Lines          727     706       -21     
===========================================
- Hits           617       0      -617     
- Misses         110     706      +596

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jamesturner246 jamesturner246 force-pushed the jamesturner246/modernise_1 branch from d2ad3a4 to 09e3020 Compare April 28, 2026 19:34
@jamesturner246 jamesturner246 force-pushed the jamesturner246/modernise_1 branch from 09e3020 to 4234bfd Compare April 28, 2026 19:35
@jamesturner246 jamesturner246 merged commit 1db64df into develop Apr 28, 2026
3 checks passed
@jamesturner246 jamesturner246 deleted the jamesturner246/modernise_1 branch April 28, 2026 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@PawelPlesniak PawelPlesniak PawelPlesniak approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jamesturner246 @codecov-commenter @PawelPlesniak @dunedaqbot