Walkthrough

Updates BlenderMCPServer.set_texture method in addon.py to support Blender 4.0+ by replacing the deprecated ShaderNodeSeparateRGB with ShaderNodeSeparateColor and adjusting corresponding input/output socket names and connections accordingly.

Changes

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐰 A shader node dance, old steps discarded,
RGB separated, Blender's heart retarded,
Color flows through, green, blue, red arrayed,
ARM channels shimmer in the upgrade's cascade,
Four-point-oh shines! ✨

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

• X
• Mastodon
• Reddit
• LinkedIn

• Replace deprecated ShaderNodeSeparateRGB with ShaderNodeSeparateColor
• Update node input/output socket names for Blender 4.0+ compatibility
• Set mode='RGB' on new node to maintain ARM channel separation
• Maintain backward compatibility with Blender 3.3+

Update ARM texture node for Blender 4.0+ compatibility

• Changed node type from ShaderNodeSeparateRGB to ShaderNodeSeparateColor with mode='RGB'
• Updated input socket name from 'Image' to 'Color'
• Updated output socket names from 'R', 'G', 'B' to 'Red', 'Green', 'Blue'
• Added explanatory comment about Blender 4.0+ compatibility change

addon.py

Description

set_texture now unconditionally creates ShaderNodeSeparateColor, which is unavailable in Blender
3.0–3.2, causing ARM texture setup to fail at runtime on those versions. This conflicts with bl_info
declaring Blender >= 3.0.0 support, turning the prior Blender-4-only failure into a Blender-3.0–3.2
failure for ARM maps.

Code

addon.py[R997-1002]

+                # Blender 4.0+ removed ShaderNodeSeparateRGB. Use ShaderNodeSeparateColor
+                # (mode='RGB'); outputs are now Red/Green/Blue, input is Color.
+                separate_rgb = nodes.new(type='ShaderNodeSeparateColor')
+                separate_rgb.mode = 'RGB'
                separate_rgb.location = (-200, -100)
-                links.new(texture_nodes['arm'].outputs['Color'], separate_rgb.inputs['Image'])
+                links.new(texture_nodes['arm'].outputs['Color'], separate_rgb.inputs['Color'])

Evidence

The addon metadata declares Blender 3.0.0 as the minimum supported version, but the modified ARM
handling path now depends on ShaderNodeSeparateColor (introduced later than 3.0) and its sockets.
The codebase already uses bpy.app.version gating for Blender API differences elsewhere, indicating
this ARM-node creation should be version-gated (or the minimum version should be raised).

addon.py[23-31]
addon.py[995-1006]
addon.py[2287-2290]

Agent prompt

The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

## Issue description
`set_texture()` now always creates `ShaderNodeSeparateColor` for ARM maps. This will break Blender 3.0–3.2 because that node type does not exist there, while `bl_info` currently declares support for Blender >= 3.0.0.

## Issue Context
- Blender 4.0+ requires `ShaderNodeSeparateColor` (since `ShaderNodeSeparateRGB` is removed).
- Blender 3.0–3.2 requires `ShaderNodeSeparateRGB` (since `ShaderNodeSeparateColor` is not available).
- The addon already uses `bpy.app.version` checks elsewhere, so follow the same pattern here.

## Fix Focus Areas
- addon.py[23-31]
- addon.py[995-1036]

## Suggested implementation outline
1. Choose node type based on `bpy.app.version` (or via `try/except` around `nodes.new`).
2. Use a small mapping for socket names:
  - SeparateRGB: input `Image`, outputs `R/G/B`
  - SeparateColor: input `Color`, outputs `Red/Green/Blue` and set `mode='RGB'`
3. Alternatively, if you intentionally drop Blender 3.0–3.2 support, bump `bl_info['blender']` to `(3, 3, 0)` and ensure release notes/docs reflect it.

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools