feat(config): expose `html.parser.vue` by dyc3 · Pull Request #9366 · biomejs/biome

dyc3 · 2026-03-06T11:54:46Z

Summary

This option was supposed to be exposed, and is referenced in error messages, but it was not exposed.

Test Plan

added cli tests

Docs

changeset-bot · 2026-03-06T11:54:51Z

🦋 Changeset detected

Latest commit: 4b6f882

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 14 packages

Name	Type
@biomejs/biome	Minor
@biomejs/cli-win32-x64	Minor
@biomejs/cli-win32-arm64	Minor
@biomejs/cli-darwin-x64	Minor
@biomejs/cli-darwin-arm64	Minor
@biomejs/cli-linux-x64	Minor
@biomejs/cli-linux-arm64	Minor
@biomejs/cli-linux-x64-musl	Minor
@biomejs/cli-linux-arm64-musl	Minor
@biomejs/wasm-web	Minor
@biomejs/wasm-bundler	Minor
@biomejs/wasm-nodejs	Minor
@biomejs/backend-jsonrpc	Patch
@biomejs/js-api	Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

codspeed-hq · 2026-03-06T12:00:41Z

Merging this PR will degrade performance by 73.51%

❌ 4 regressed benchmarks
✅ 64 untouched benchmarks
⏩ 188 skipped benchmarks¹

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

	Benchmark	`BASE`	`HEAD`	Efficiency
❌	`html_analyzer[real/wikipedia-fr-Guerre_de_Canudos.html]`	450.6 ms	1,488 ms	-69.72%
❌	`html_analyzer[real/wikipedia-Unix.html]`	166.2 ms	592.3 ms	-71.94%
❌	`html_analyzer[index_1033418810622582172.html]`	469.2 µs	1,349.7 µs	-65.23%
❌	`html_analyzer[real/wikipedia-JavaScript.html]`	189.3 ms	714.5 ms	-73.51%

_{Comparing dyc3/html-parser-vue-config (4b6f882) with next (aaf4af0)}

188 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

ematipico

I would like to have a discussion about the applicability of this option.

I think it's safer to target only .html files, not .astro and .svelte.

However, if we've set on this, we need to document how users can opt out.

Also, there must be a docs PR

coderabbitai · 2026-03-22T17:37:06Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: ce5135c2-2e56-4550-bece-95e366445d2e

📥 Commits

Reviewing files that changed from the base of the PR and between fc44d5f and 4b6f882.

⛔ Files ignored due to path filters (2)

packages/@biomejs/backend-jsonrpc/src/workspace.ts is excluded by !**/backend-jsonrpc/src/workspace.ts and included by **
packages/@biomejs/biome/configuration_schema.json is excluded by !**/configuration_schema.json and included by **

📒 Files selected for processing (5)

.changeset/expose-html-parser-vue-option.md
crates/biome_configuration/src/html.rs
crates/biome_service/src/lib.rs
crates/biome_service/src/settings.rs
crates/biome_service/src/settings.tests.rs

✅ Files skipped from review due to trivial changes (1)

.changeset/expose-html-parser-vue-option.md

🚧 Files skipped from review as they are similar to previous changes (3)

crates/biome_service/src/settings.rs
crates/biome_configuration/src/html.rs
crates/biome_service/src/settings.tests.rs

Walkthrough

This PR exposes the html.parser.vue configuration option, adds a boolean HtmlParseVue type and an optional vue field on HtmlParserConfiguration, threads the setting into HtmlParserSettings and HtmlParserOptions (including a set_vue mutator), and updates service settings so Vue parsing is only enabled for HTML inputs. Tests were added to verify Vue directive parsing is enabled for .html and remains disabled for .astro/.svelte. The test_utils module compilation gating was broadened for test builds.

Possibly related PRs

fix(parse/html): fix disabled vue error message #9879: Updates the disabled-Vue diagnostic message that referenced the html.parser.vue option now exposed by this PR.

Suggested reviewers

ematipico

🚥 Pre-merge checks | ✅ 4

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly and concisely describes the main objective: exposing the previously hidden `html.parser.vue` configuration option.
Description check	✅ Passed	The description accurately explains the motivation (exposing a referenced but unexposed option) and notes that CLI tests were added for validation.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch dyc3/html-parser-vue-config

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

coderabbitai

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@crates/biome_cli/tests/cases/html.rs`:
- Around line 444-528: The two tests should only differ by the parser.vue flag;
update the should_error_when_vue_is_disabled test so its biome.json parser block
explicitly sets "interpolation": true (and "vue": false) to match
should_not_error_when_vue_is_enabled except for vue, ensuring the regression is
isolated; locate the test function should_error_when_vue_is_disabled and adjust
the JSON under the Utf8Path::new("biome.json") insert so parser.interpolation is
true while parser.vue is false, keeping linter.enabled true and leaving
run_cli/Args/SnapshotPayload usage unchanged.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

Push a commit to this branch (recommended)
Create a new PR with the fixes

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 4c196fb7-4a0c-4ded-8a73-0fea02836c70

📥 Commits

Reviewing files that changed from the base of the PR and between 2093e3e and fc44d5f.

⛔ Files ignored due to path filters (4)

crates/biome_cli/tests/snapshots/main_cases_html/should_error_when_vue_is_disabled.snap is excluded by !**/*.snap and included by **
crates/biome_cli/tests/snapshots/main_cases_html/should_not_error_when_vue_is_enabled.snap is excluded by !**/*.snap and included by **
packages/@biomejs/backend-jsonrpc/src/workspace.ts is excluded by !**/backend-jsonrpc/src/workspace.ts and included by **
packages/@biomejs/biome/configuration_schema.json is excluded by !**/configuration_schema.json and included by **

📒 Files selected for processing (7)

.changeset/expose-html-parser-vue-option.md
crates/biome_cli/tests/cases/html.rs
crates/biome_configuration/src/html.rs
crates/biome_html_parser/src/parser.rs
crates/biome_service/src/file_handlers/html.rs
crates/biome_service/src/settings.rs
crates/biome_service/src/settings.tests.rs

coderabbitai · 2026-04-26T13:27:44Z

+#[test]
+fn should_error_when_vue_is_disabled() {
+    let fs = MemoryFileSystem::default();
+    let mut console = BufferConsole::default();
+
+    let html_file = Utf8Path::new("file.html");
+    fs.insert(
+        html_file.into(),
+        r#"<div v-if="show">{{ message }}</div>
+"#
+        .as_bytes(),
+    );
+    fs.insert(
+        Utf8Path::new("biome.json").into(),
+        r#"{
+    "html": {
+        "linter": {
+            "enabled": true
+        }
+    }
+}"#
+        .as_bytes(),
+    );
+
+    let (fs, result) = run_cli(
+        fs,
+        &mut console,
+        Args::from(["lint", html_file.as_str()].as_slice()),
+    );
+
+    assert!(result.is_err(), "run_cli returned {result:?}");
+
+    assert_cli_snapshot(SnapshotPayload::new(
+        module_path!(),
+        "should_error_when_vue_is_disabled",
+        fs,
+        console,
+        result,
+    ));
+}
+
+#[test]
+fn should_not_error_when_vue_is_enabled() {
+    let fs = MemoryFileSystem::default();
+    let mut console = BufferConsole::default();
+
+    let html_file = Utf8Path::new("file.html");
+    fs.insert(
+        html_file.into(),
+        r#"<div v-if="show">{{ message }}</div>
+"#
+        .as_bytes(),
+    );
+    fs.insert(
+        Utf8Path::new("biome.json").into(),
+        r#"{
+    "html": {
+        "parser": {
+            "vue": true,
+            "interpolation": true
+        },
+        "linter": {
+            "enabled": true
+        }
+    }
+}"#
+        .as_bytes(),
+    );
+
+    let (fs, result) = run_cli(
+        fs,
+        &mut console,
+        Args::from(["lint", html_file.as_str()].as_slice()),
+    );
+
+    assert!(result.is_ok(), "run_cli returned {result:?}");
+
+    assert_cli_snapshot(SnapshotPayload::new(
+        module_path!(),
+        "should_not_error_when_vue_is_enabled",
+        fs,
+        console,
+        result,
+    ));
+}


⚠️ Potential issue | 🟠 Major

Vue toggle tests are coupled to interpolation and can mask regressions.

Right now the “disabled” case can fail purely because interpolation is off, even if Vue parsing wiring breaks. Please isolate the variable under test so only parser.vue differs.

Suggested test adjustment

@@ - r#"<div v-if="show">{{ message }}</div> + r#"<div v-if="show"></div> "# @@ "html": { + "parser": { + "interpolation": true + }, "linter": { "enabled": true } @@ - r#"<div v-if="show">{{ message }}</div> + r#"<div v-if="show"></div> "# @@ "parser": { "vue": true, "interpolation": true },

As per coding guidelines: “All code changes MUST include appropriate tests … and bug fixes require tests that reproduce and validate the fix.”

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed. In `@crates/biome_cli/tests/cases/html.rs` around lines 444 - 528, The two tests should only differ by the parser.vue flag; update the should_error_when_vue_is_disabled test so its biome.json parser block explicitly sets "interpolation": true (and "vue": false) to match should_not_error_when_vue_is_enabled except for vue, ensuring the regression is isolated; locate the test function should_error_when_vue_is_disabled and adjust the JSON under the Utf8Path::new("biome.json") insert so parser.interpolation is true while parser.vue is false, keeping linter.enabled true and leaving run_cli/Args/SnapshotPayload usage unchanged.

github-actions Bot added A-Project Area: project A-Parser Area: parser L-HTML Language: HTML and super languages labels Mar 6, 2026

dyc3 force-pushed the dyc3/html-parser-vue-config branch from 76ac82f to e4b6fea Compare March 6, 2026 12:04

github-actions Bot added the A-CLI Area: CLI label Mar 6, 2026

dyc3 force-pushed the dyc3/html-parser-vue-config branch from e4b6fea to 0bbda9e Compare March 6, 2026 12:07

dyc3 marked this pull request as ready for review March 6, 2026 12:19

chansuke approved these changes Mar 7, 2026

View reviewed changes

ematipico requested changes Mar 7, 2026

View reviewed changes

Comment thread .changeset/expose-html-parser-vue-option.md Outdated

Comment thread crates/biome_configuration/src/html.rs Outdated

dyc3 added this to the Biome v2.5 milestone Mar 7, 2026

dyc3 force-pushed the dyc3/html-parser-vue-config branch from 26d2dd3 to 41db234 Compare March 22, 2026 17:25

dyc3 changed the base branch from main to next March 22, 2026 17:27

dyc3 self-assigned this Apr 25, 2026

dyc3 and others added 2 commits April 26, 2026 09:20

feat(config): expose html.parser.vue

e99cfc4

[autofix.ci] apply automated fixes

aff0688

dyc3 force-pushed the dyc3/html-parser-vue-config branch from 41db234 to fc44d5f Compare April 26, 2026 13:22

dyc3 requested a review from ematipico April 26, 2026 13:22

github-actions Bot removed the A-Linter Area: linter label Apr 26, 2026

github-actions Bot removed A-Tooling Area: internal tools A-LSP Area: language server protocol L-CSS Language: CSS and super languages A-Diagnostic Area: diagnostocis L-Grit Language: GritQL A-Resolver Area: resolver labels Apr 26, 2026

coderabbitai Bot reviewed Apr 26, 2026

View reviewed changes

fix: only apply to html files

4b6f882

dyc3 force-pushed the dyc3/html-parser-vue-config branch from fc44d5f to 4b6f882 Compare April 26, 2026 17:08

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat(config): expose `html.parser.vue`#9366

feat(config): expose `html.parser.vue`#9366
dyc3 wants to merge 3 commits intonextfrom
dyc3/html-parser-vue-config

dyc3 commented Mar 6, 2026 •

edited

Loading

Uh oh!

changeset-bot Bot commented Mar 6, 2026 •

edited

Loading

Uh oh!

codspeed-hq Bot commented Mar 6, 2026 •

edited

Loading

Uh oh!

ematipico left a comment

Uh oh!

Uh oh!

Uh oh!

coderabbitai Bot commented Mar 22, 2026 •

edited

Loading

Uh oh!

coderabbitai Bot left a comment

Uh oh!

coderabbitai Bot Apr 26, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

dyc3 commented Mar 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Test Plan

Docs

Uh oh!

changeset-bot Bot commented Mar 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

codspeed-hq Bot commented Mar 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merging this PR will degrade performance by 73.51%

Performance Changes

Footnotes

Uh oh!

ematipico left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

coderabbitai Bot commented Mar 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Possibly related PRs

Suggested reviewers

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

coderabbitai Bot Apr 26, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

dyc3 commented Mar 6, 2026 •

edited

Loading

changeset-bot Bot commented Mar 6, 2026 •

edited

Loading

codspeed-hq Bot commented Mar 6, 2026 •

edited

Loading

coderabbitai Bot commented Mar 22, 2026 •

edited

Loading