feat(prefork): delegate to fasthttp/prefork to eliminate code duplication by ReneWerner87 · Pull Request #4210 · gofiber/fiber

ReneWerner87 · 2026-04-11T19:33:00Z

Summary

Replaces previous PR #4037 (accidentally merged via branch tracking misconfiguration).

Replace Fiber's own prefork implementation with fasthttp's prefork package
Eliminate ~100 lines of duplicated process management logic
Add PreforkRecoverThreshold to ListenConfig for configurable child recovery
Add PreforkLogger to ListenConfig for configurable prefork logging
IsChild() delegates to prefork.IsChild()
Callbacks (OnChildSpawn, OnMasterReady, OnChildRecover) integrate Fiber's hooks
New prefork_logger.go with PreforkLoggerInterface

Depends on

https://github.com/ReneWerner87/fasthttp (prefork_optimization branch) — adds OnMasterDeath, OnChildSpawn, OnMasterReady, OnChildRecover, CommandProducer to fasthttp/prefork

valyala/fasthttp#2180

Test plan

All prefork tests pass (child, master, TLS, mTLS, hooks)
Full fiber test suite passes (27s)
FastHTTP prefork tests pass (20/20)
gosec security scan: 0 issues

🤖 Generated with Claude Code

…tion Replace Fiber's own prefork implementation with fasthttp's prefork package. This eliminates duplicated process management logic and adds new features: - IsChild() now delegates to prefork.IsChild() - Master process uses fasthttp's recovery loop (RecoverThreshold) - Callbacks (OnChildSpawn, OnMasterReady, OnChildRecover) integrate Fiber's hooks system (OnFork, OnListen, startup message) - CommandProducer enables clean test injection (replaces testPreforkMaster) - OnMasterDeath replaces Fiber's watchMaster (now in fasthttp) - New PreforkRecoverThreshold field in ListenConfig - prefork_logger.go adapts Fiber's logger to fasthttp's Logger interface - go.mod uses replace directive for local fasthttp development Code reduction: ~200 lines of process management removed from Fiber. All existing tests adapted for recovery behavior (ErrOverRecovery). Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>

Ensures deterministic and fast execution regardless of GOMAXPROCS count. Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>

Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>

Use github.com/ReneWerner87/fasthttp@2802b1a (prefork_optimization branch) instead of local ../fasthttp path, so CI and other developers can resolve the dependency. Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>

Includes fix for ListenAndServeTLS parameter order preservation. Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>

- prefork_logger.go: use grouped import declaration - prefork.go: rename unused 'files' parameter to '_' - prefork.go: wrap external errors from cmd.Start() and ListenAndServe() Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>

- Move windowsOS constant to constants.go (global consts file) - Make prefork logger configurable via ListenConfig.PreforkLogger - Define PreforkLoggerInterface for custom logger implementations - Use logger.Printf instead of direct log.Warnf in OnChildRecover - Remove unused log import from prefork.go Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>

coderabbitai · 2026-04-11T19:33:08Z

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: ae4aea3e-86be-49f6-8b2c-538e17874648

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch prefork_optimization

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

gemini-code-assist

Code Review

This pull request refactors the preforking mechanism by delegating process management to the fasthttp/prefork package, simplifying the internal implementation and adding support for recovery thresholds and custom loggers. Feedback highlights a security and maintenance risk regarding the use of a personal fork for fasthttp, a bug in the test command producer that starts processes prematurely, and a logic issue where the default recovery threshold could be zero on single-core systems.

…tems runtime.GOMAXPROCS(0)/2 yields 0 on single-core, disabling recovery. Use max(1, ...) to guarantee at least one recovery attempt. Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>

codecov · 2026-04-12T17:38:34Z

Codecov Report

❌ Patch coverage is 91.66667% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 91.23%. Comparing base (6c19f48) to head (4f06076).
⚠️ Report is 118 commits behind head on main.

Files with missing lines	Patch %	Lines
prefork.go	91.17%	1 Missing and 2 partials ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #4210      +/-   ##
==========================================
+ Coverage   91.16%   91.23%   +0.06%     
==========================================
  Files         123      124       +1     
  Lines       11855    12064     +209     
==========================================
+ Hits        10808    11006     +198     
- Misses        659      662       +3     
- Partials      388      396       +8

Flag	Coverage Δ
unittests	`91.23% <91.66%> (+0.06%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Includes lint fixes and review feedback for CommandProducer validation. Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>

OnChildRecover no longer returns an error (simplified API). Update fasthttp fork reference to 9758f93. Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>

OnChildRecover now receives both the crashed and replacement PID. OnFork hooks for recovered children are handled by OnChildSpawn which fasthttp now calls for recoveries too. Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>

Includes zombie process fix and lifecycle integration test. Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>

github-actions

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.50.

Benchmark suite	Current: `4f06076`	Previous: `f6ecd99`	Ratio
`Benchmark_Compress/Zstd (github.com/gofiber/fiber/v3/middleware/compress) - B/op`	`1` B/op	`0` B/op	`+∞`
`Benchmark_Compress_Levels/Zstd_LevelDefault (github.com/gofiber/fiber/v3/middleware/compress) - B/op`	`1` B/op	`0` B/op	`+∞`
`Benchmark_Compress_Levels/Zstd_LevelBestCompression (github.com/gofiber/fiber/v3/middleware/compress) - B/op`	`1` B/op	`0` B/op	`+∞`

This comment was automatically generated by workflow using github-action-benchmark.

ReneWerner87 and others added 7 commits April 11, 2026 20:09

test(prefork): add PreforkRecoverThreshold to invalid-command test case

dba20e1

Ensures deterministic and fast execution regardless of GOMAXPROCS count. Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>

refactor(prefork): use windowsOS constant in dummyCmd for consistency

cfc5a9d

Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>

build: update fasthttp fork reference to c1055ce

3124fc2

Includes fix for ListenAndServeTLS parameter order preservation. Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>

ReneWerner87 added v3 ✏️ Feature 🤖 Dependencies labels Apr 11, 2026

ReneWerner87 added this to v3 Apr 11, 2026

ReneWerner87 added this to the v3 milestone Apr 11, 2026

ReneWerner87 removed the 🤖 Dependencies label Apr 11, 2026

ReneWerner87 mentioned this pull request Apr 11, 2026

feat(prefork): add support for process monitoring and callbacks in prefork mode #4037

Merged

gemini-code-assist Bot reviewed Apr 11, 2026

View reviewed changes

Comment thread go.mod Outdated

Comment thread prefork.go

Comment thread prefork.go Outdated

fix(prefork): ensure minimum RecoverThreshold of 1 on single-core sys…

696dfc2

…tems runtime.GOMAXPROCS(0)/2 yields 0 on single-core, disabling recovery. Use max(1, ...) to guarantee at least one recovery attempt. Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>

ReneWerner87 added the 🤖 Dependencies label Apr 12, 2026

ReneWerner87 mentioned this pull request Apr 12, 2026

feat(prefork): Enhance prefork management with WatchMaster, CommandProducer, and Windows support valyala/fasthttp#2180

Open

ReneWerner87 and others added 6 commits April 13, 2026 08:39

build: update fasthttp fork reference to be2ef67

b0d1e8c

Includes lint fixes and review feedback for CommandProducer validation. Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>

refactor(prefork): update OnChildRecover signature and fasthttp ref

f2307e1

OnChildRecover no longer returns an error (simplified API). Update fasthttp fork reference to 9758f93. Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>

build: update fasthttp fork reference to eac6a01

43dd29b

Includes zombie process fix and lifecycle integration test. Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>

build: update fasthttp fork reference

aa24edd

build: update fasthttp fork reference

4f06076

github-actions Bot reviewed Apr 29, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat(prefork): delegate to fasthttp/prefork to eliminate code duplication#4210

feat(prefork): delegate to fasthttp/prefork to eliminate code duplication#4210
ReneWerner87 wants to merge 14 commits intomainfrom
prefork_optimization

ReneWerner87 commented Apr 11, 2026 •

edited

Loading

Uh oh!

coderabbitai Bot commented Apr 11, 2026 •

edited

Loading

Review skipped

Uh oh!

gemini-code-assist Bot left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

codecov Bot commented Apr 12, 2026 •

edited

Loading

Uh oh!

github-actions Bot left a comment •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Conversation

ReneWerner87 commented Apr 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Depends on

Test plan

Uh oh!

coderabbitai Bot commented Apr 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

codecov Bot commented Apr 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

github-actions Bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

⚠️ Performance Alert ⚠️

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

ReneWerner87 commented Apr 11, 2026 •

edited

Loading

coderabbitai Bot commented Apr 11, 2026 •

edited

Loading

codecov Bot commented Apr 12, 2026 •

edited

Loading

github-actions Bot left a comment •

edited

Loading