Move Hilt's field/method descriptor logic into separate class.#3365
Open
copybara-service[bot] wants to merge 1 commit intomasterfrom
Open
Move Hilt's field/method descriptor logic into separate class.#3365copybara-service[bot] wants to merge 1 commit intomasterfrom
copybara-service[bot] wants to merge 1 commit intomasterfrom
Conversation
a66aeb3 to
4879f74
Compare
This CL refactors Hilt's field/method descriptor logic out of KotlinMetadata and into a separate ElementDescriptors class. This allows BroadcastReceiverGenerator to share the logic and remove its dependency on DaggerElements, which will be removed during the XProcessing migration. This CL also forks over Dagger's ElementDescriptorsTest. The Dagger version of this test will be removed once DaggerElements is removed. RELNOTES=N/A PiperOrigin-RevId: 443760163
0585546 to
be32794
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move Hilt's field/method descriptor logic into separate class.
This CL refactors Hilt's field/method descriptor logic out of KotlinMetadata and into a separate ElementDescriptors class. This allows BroadcastReceiverGenerator to share the logic and remove its dependency on DaggerElements, which will be removed during the XProcessing migration.
This CL also forks over Dagger's ElementDescriptorsTest. The Dagger version of this test will be removed once DaggerElements is removed.
RELNOTES=N/A