Fix O(N^2) performance issue when determining declaration order.#3372
Open
copybara-service[bot] wants to merge 1 commit intomasterfrom
Open
Fix O(N^2) performance issue when determining declaration order.#3372copybara-service[bot] wants to merge 1 commit intomasterfrom
copybara-service[bot] wants to merge 1 commit intomasterfrom
Conversation
Note: This CL fixes the issue for `InjectionSiteFactory`, but I ended up just inlining the last remaining (unfixed) usage into `DiagnosticMessageGenerator`. Looks like there's a number of similar comparators within `DiagnosticMessageGenerator`, which we may want to eventually look into fixing them all at some point. On the other hand, the `DiagnosticMessageGenerator` only runs when there's errors so it's likely not as big of an issue. RELNOTES=N/A PiperOrigin-RevId: 444923305
cca07a1 to
1a01575
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix O(N^2) performance issue when determining declaration order.
Note: This CL fixes the issue for
InjectionSiteFactory, but I ended up just inlining the last remaining (unfixed) usage intoDiagnosticMessageGenerator.Looks like there's a number of similar comparators within
DiagnosticMessageGenerator, which we may want to eventually look into fixing them all at some point. On the other hand, theDiagnosticMessageGeneratoronly runs when there's errors so it's likely not as big of an issue.RELNOTES=N/A