Add support for calling fiddle tagging methods inside auto_config functions.#90
Open
copybara-service[bot] wants to merge 1 commit intomainfrom
Open
Add support for calling fiddle tagging methods inside auto_config functions.#90copybara-service[bot] wants to merge 1 commit intomainfrom
copybara-service[bot] wants to merge 1 commit intomainfrom
Conversation
…ctions. When the auto_config function is run using as_buildable, the tagging methods work as normal. E.g.: - MyTag.new(x) returns TaggedValueCls([MyTag], x). - fdl.add_tag(cfg, 'arg', MyTag) adds the tag MyTag to cfg.arg. - fdl.get_tags(cfg, 'arg') returns the tags for cfg.arg. When the auto_config function is run using __call__, the tagging methods are no-ops. E.g.: - MyTag.new(x) returns x. - fdl.add_tag(cfg, arg, MyTag) does nothing and returns None. - fdl.get_tags(cfg, arg) returns an empty frozenset. PiperOrigin-RevId: 466052435
f7d6d4b to
0e982e3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for calling fiddle tagging methods inside auto_config functions.
When the auto_config function is run using as_buildable, the tagging methods work as normal. E.g.:
When the auto_config function is run using call, the tagging methods are no-ops. E.g.: