Change the behavior of auto_config'ed functions when called normally. Previously, if ac=AutoConfig(func, buildable_func), then ac(*args, *kwargs) would return func(*args, **kwargs). This CL updates it to instead return fdl.build(buildable_func(*args, *kwargs)).#94
Open
copybara-service[bot] wants to merge 1 commit intomainfrom
Open
Change the behavior of auto_config'ed functions when called normally. Previously, if ac=AutoConfig(func, buildable_func), then ac(*args, *kwargs) would return func(*args, **kwargs). This CL updates it to instead return fdl.build(buildable_func(*args, *kwargs)).#94copybara-service[bot] wants to merge 1 commit intomainfrom
ac=AutoConfig(func, buildable_func), then ac(*args, *kwargs) would return func(*args, **kwargs). This CL updates it to instead return fdl.build(buildable_func(*args, *kwargs)).#94copybara-service[bot] wants to merge 1 commit intomainfrom
Conversation
… Previously, if `ac=AutoConfig(func, buildable_func)`, then `ac(*args, *kwargs)` would return `func(*args, **kwargs)`. This CL updates it to instead return `fdl.build(buildable_func(*args, *kwargs))`. This will help ensure that the two modes that an autoconfig function can be used with (__call__ and as_buildable) have consistent behavior. If you want the old behavior (for debugging), you can use a new context manager (`with debug_auto_config:`). This CL also makes it possible to call fiddle tagging methods inside auto_config functions (e.g., `fdl.add_tag` and `MyTag.new`). PiperOrigin-RevId: 466416396
bad876c to
a999f0b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change the behavior of auto_config'ed functions when called normally. Previously, if
ac=AutoConfig(func, buildable_func), thenac(*args, *kwargs)would returnfunc(*args, **kwargs). This CL updates it to instead returnfdl.build(buildable_func(*args, *kwargs)).This will help ensure that the two modes that an autoconfig function can be used with (call and as_buildable) have consistent behavior.
If you want the old behavior (for debugging), you can use a new context manager (
with debug_auto_config:).This CL also makes it possible to call fiddle tagging methods inside auto_config functions (e.g.,
fdl.add_tagandMyTag.new).