feat(gcloud): add GcloudSurface config and map to provider.Config#5688
Open
jameslynnwu wants to merge 6 commits intogoogleapis:mainfrom
Open
feat(gcloud): add GcloudSurface config and map to provider.Config#5688jameslynnwu wants to merge 6 commits intogoogleapis:mainfrom
jameslynnwu wants to merge 6 commits intogoogleapis:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces gcloud-specific library configuration, specifically adding a GenerateOperations flag to control the generation of top-level operations commands. The changes include defining the GcloudSurface struct, updating the Library configuration, and adjusting the generation logic to utilize these new settings. A unit test was also added to ensure correct YAML unmarshaling. Feedback was provided to reorder the Gcloud field alphabetically within the Library struct to maintain consistency.
julieqiu
reviewed
Apr 29, 2026
julieqiu
reviewed
Apr 29, 2026
julieqiu
reviewed
Apr 29, 2026
Add support for GcloudSurface configuration in librarian.yaml. Update internal/config to parse it, and internal/librarian/gcloud to map GenerateOperations to provider.Config when calling sidekick/gcloud.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Signed-off-by: James Wu <[email protected]>
…tions Help text overrides are now supported in librarian.yaml for gcloud generation, allowing customization of method and field help text.
9f89a70 to
cc51211
Compare
cc51211 to
e045b47
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for GcloudSurface configuration in librarian.yaml.
Help text overrides are now supported in librarian.yaml for gcloud generation, allowing customization of method and field help text. Only MethodRules and FieldRules help text overrides are implemented, even though ServiceRules and MessageRules help text overrides are defined in gcloud.yaml schema, since they are not implemented in librarian yet.