Skip to content

chore(prebuiltconfigs): update prebuilt file to follow naming convention#3134

Open
Yuan325 wants to merge 1 commit intomainfrom
update-prebuilt-names
Open

chore(prebuiltconfigs): update prebuilt file to follow naming convention#3134
Yuan325 wants to merge 1 commit intomainfrom
update-prebuilt-names

Conversation

@Yuan325
Copy link
Copy Markdown
Contributor

@Yuan325 Yuan325 commented Apr 28, 2026

Update tool names that are not following our convention (snake case + do not include source type).

@Yuan325 Yuan325 requested a review from a team as a code owner April 28, 2026 03:03
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates prebuilt configuration files for conversational analytics, Elasticsearch, and MindsDB to use snake_case for tool and toolset names, aligning with the project's style guide. Feedback indicates that renaming the source in the conversational analytics configuration has broken references in the associated tools, which will lead to initialization errors.


kind: source
name: conversational-analytics-source
name: conversational_analytics_source
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

Renaming the source to conversational_analytics_source breaks the references in the tools defined later in this file (lines 24, 33, and 42), which still use the old kebab-case name conversational-analytics-source. This will cause tool initialization to fail as the referenced source will not be found.

@Yuan325 Yuan325 force-pushed the update-prebuilt-names branch from bca2c8b to e07e11a Compare April 28, 2026 03:06
@Yuan325 Yuan325 force-pushed the update-prebuilt-names branch from e07e11a to 462cfbf Compare April 28, 2026 03:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants