Fix CSE hash collision in value numbering#581
Open
eric wants to merge 1 commit intogorgonia:masterfrom
Open
Conversation
The value numbering function vn() used only the 32-bit FNV hash to determine if two nodes are equivalent for common subexpression elimination. When two different nodes had a hash collision, the second node was incorrectly treated as a duplicate of the first, causing it to share the first node's register and interval. This led to the wrong value being read at execution time. For example, a slice op producing shape (1,1,5) could hash-collide with a MatMul producing shape (10000,1). The MatMul would be treated as equivalent to the slice op, and any consumer of the MatMul would read the slice op's value instead. The fix adds a nodeEq check to verify actual equivalence before declaring a CSE match, consistent with how ExprGraph.AddNode already handles hash collisions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The value numbering function vn() used only the 32-bit FNV hash to determine if two nodes are equivalent for common subexpression elimination. When two different nodes had a hash collision, the second node was incorrectly treated as a duplicate of the first, causing it to share the first node's register and interval. This led to the wrong value being read at execution time.
For example, a slice op producing shape (1,1,5) could hash-collide with a MatMul producing shape (10000,1). The MatMul would be treated as equivalent to the slice op, and any consumer of the MatMul would read the slice op's value instead.
The fix adds a nodeEq check to verify actual equivalence before declaring a CSE match, consistent with how ExprGraph.AddNode already handles hash collisions.