Skip to content

Fix broken search #999

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ksuess merged 5 commits into from
Mar 5, 2026
Merged

Fix broken search #999

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
b2008d2
Fix potential error by ensuring stopwords is defined before checking …
ksuess Feb 27, 2026
a81aa52
Ensure docUrlRoot is defined with a fallback to an empty string
ksuess Feb 27, 2026
603432c
fix check on stopwords: stopwords is a set
ksuess Feb 27, 2026
1ba259a
Fix search facet option
ksuess Feb 27, 2026
51f0b74
Remove outdated training options from search field
ksuess Feb 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions docs/_static/searchtools.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,7 @@ function _getBreadcrumbs(item, linkUrl) {

const _displayItem = (item, searchTerms) => {
const docBuilder = DOCUMENTATION_OPTIONS.BUILDER;
const docUrlRoot = DOCUMENTATION_OPTIONS.URL_ROOT;
const docUrlRoot = DOCUMENTATION_OPTIONS.URL_ROOT || "";
const docFileSuffix = DOCUMENTATION_OPTIONS.FILE_SUFFIX;
const docLinkSuffix = DOCUMENTATION_OPTIONS.LINK_SUFFIX;
const showSearchSummary = DOCUMENTATION_OPTIONS.SHOW_SEARCH_SUMMARY;
Expand Down Expand Up @@ -326,7 +326,7 @@ const Search = {
// maybe skip this "word"
// stopwords array is from language_data.js
if (
stopwords.indexOf(queryTermLower) !== -1 ||
stopwords.has(queryTermLower) ||
queryTerm.match(/^\d+$/)
)
return;
Expand Down
8 changes: 1 addition & 7 deletions docs/_templates/components/search-field.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,15 +26,9 @@
[
['content-editing', 'Content Editing for Plone'],
['mastering-plone', 'Mastering Plone development'],
['volto_customization','Volto customization for JavaScript beginners'],
['volto-customization','Volto customization for JavaScript beginners'],
['customizing-volto-light-theme','Customizing Volto Light Theme'],
['voltohandson','Volto Hands-On (beginner)'],
['voltoaddons','Volto add-ons'],
['effective-volto','Effective Volto (advanced)'],
['testing','Testing'],
['theming','Plone 6 Classic UI Theming'],
['plone-deployment','Deployment'],
['workflow','Workflow'],
['migrations','Migration best practice'],
['contributing', 'Contributing to Plone'],
] %}
Expand Down