fix(ts): type definitions are not resolvable without proper types fields in package.json#170
Merged
rvagg merged 2 commits intorvagg:masterfrom Apr 30, 2026
Merged
Conversation
Owner
|
can you rebase onto master (tsconfig.tsbuildinfo is gone for a start) and not reorder things but just add the |
…lds in package.json
Contributor
Author
|
@rvagg yes, done! (oops, followed up with the deps reorder, that was done automatically by npm on The types line proceeding the import line is part of the fix, surprisingly, order matters (we had the same bug on bson a ways back) here's the documentation that points out that "types" comes first had to dig it up for myself 😅 |
Owner
🤯 thanks for this! TIL |
rvagg
approved these changes
Apr 30, 2026
github-actions Bot
pushed a commit
that referenced
this pull request
Apr 30, 2026
## [7.0.2](v7.0.1...v7.0.2) (2026-04-30) ### Bug Fixes * **ts:** type definitions are not resolvable without proper types fields in package.json ([#170](#170)) ([22c02e6](22c02e6))
|
🎉 This PR is included in version 7.0.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi! It seems like the type definitions are not importable in the current release just because of these small quirks about how you have to put the
"types"fields in the package.json.Here's a site that provides a test:
https://arethetypeswrong.github.io/?p=bl%407.0.0