Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #3566 +/- ##
==========================================
+ Coverage 60.51% 60.62% +0.11%
==========================================
Files 652 653 +1
Lines 45340 45574 +234
==========================================
+ Hits 27439 27631 +192
- Misses 17901 17943 +42
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Signed-off-by: Siarhiej Siemianczuk <[email protected]>
| in := bufio.NewReader(&inBuf) | ||
| f := setupPreCallback(tt.recursive, tt.ask, tt.force, &out, *in) | ||
| srcfi, err := os.Stat(tt.args[0]) | ||
| // If the src file does not exist, there is no point in continue, but it is not an error so the say. |
There was a problem hiding this comment.
I do not understand this comment. It may have been in the original but this may be a good time to fix it?
There was a problem hiding this comment.
I don't understand it either, no sure what is even need to be fixed here.
There was a problem hiding this comment.
there's another problem here now. tt.args[0] is "cp", not the source file. I think this should be args[1]?
There was a problem hiding this comment.
it calls run directly, in run we have this where cp is skipped:
fs.Parse(unixflag.ArgsToGoArgs(args[1:]))
So cp as first argument is ok for this test.
There was a problem hiding this comment.
I did some cleaning, and removed some "tests" that don't really test anything. But I think cp need more work, but let's do it later.
remove broken tests, they send "cp" as a first argument and always return an cp.ErrSkip or nil Signed-off-by: Siarhiej Siemianczuk <[email protected]>
No description provided.