tests/server/consolidated/character-manage.test.ts (1)

102-115: Assert persisted inventory state, not just _provisioning.

This regression still only checks the handler response. Since issue #45 was specifically a failed write to inventory_items, please also verify the created character has persisted inventory rows after creation—ideally by querying through InventoryRepository or the DB and checking for expected starter items per class.

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@tests/server/consolidated/character-manage.test.ts` around lines 102 - 115,
The test currently only asserts the handler response (_provisioning) but must
also assert persisted inventory rows to catch failed writes to inventory_items;
after each handleCharacterManage call, load the created character's inventory
via InventoryRepository (or a direct DB query) using the returned character id
from parsed, then assert that InventoryRepository.findByCharacterId (or
equivalent) returns >0 rows and contains the expected starter item(s) for that
class (e.g., Paladin, Rogue, Wizard, Cleric, Fighter); update the test to fail
if no persisted inventory rows exist or expected starter items are missing.

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

src/server/consolidated/character-manage.ts (1)

224-257: Post-provisioning update correctly persists spell-related fields.

The flow is sound:

1. Provisioning runs against the existing character row
2. Spell fields are derived from provisioning result and merged with args
3. A single update() call persists all spell-related changes

One minor observation: the as any cast on line 256 bypasses type checking on the update payload.

🔧 Consider defining the update payload type explicitly

Instead of as any, you could define a typed partial:

-        characterRepo.update(characterId, {
-            knownSpells: character.knownSpells as string[],
-            cantripsKnown: character.cantripsKnown as string[],
-            spellSlots: character.spellSlots,
-            pactMagicSlots: character.pactMagicSlots
-        } as any);
+        const spellUpdates: Partial<{
+            knownSpells: string[];
+            cantripsKnown: string[];
+            spellSlots: ReturnType<typeof convertSpellSlotsToObject>;
+            pactMagicSlots: typeof character.pactMagicSlots;
+        }> = {
+            knownSpells: character.knownSpells as string[],
+            cantripsKnown: character.cantripsKnown as string[],
+            spellSlots: character.spellSlots,
+            pactMagicSlots: character.pactMagicSlots
+        };
+        characterRepo.update(characterId, spellUpdates as Parameters<typeof characterRepo.update>[1]);

This is a minor improvement and can be deferred.

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@src/server/consolidated/character-manage.ts` around lines 224 - 257, The
update call to characterRepo.update uses an unsafe cast ("as any") for the
payload; replace it with a properly typed partial object so TypeScript enforces
field types. Locate the provisioning block around
provisionStartingEquipment(...) and the subsequent assignments to
character.knownSpells, character.cantripsKnown, character.spellSlots, and
character.pactMagicSlots, then call characterRepo.update(characterId, payload)
where payload is typed (e.g., Partial<CharacterRow> or the repository's expected
update type) and contains knownSpells: string[], cantripsKnown: string[],
spellSlots: SpellSlotsType, pactMagicSlots?: PactMagicType; remove the "as any"
cast and adjust conversions (convertSpellSlotsToObject return type) to satisfy
the update signature.