Skip to content

internal_replication should be false, if there is a single replica. #422

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sunsingerus merged 1 commit into from
Jun 16, 2020
Merged

internal_replication should be false, if there is a single replica. #422

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions pkg/model/normalizer.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ import (
// log "k8s.io/klog"

"gopkg.in/d4l3k/messagediff.v1"
"k8s.io/api/core/v1"
v1 "k8s.io/api/core/v1"
v12 "k8s.io/apimachinery/pkg/apis/meta/v1"
)

Expand Down Expand Up @@ -1557,8 +1557,11 @@ func (n *Normalizer) normalizeHostPorts(host *chiv1.ChiHost) {
// normalizeShardInternalReplication ensures reasonable values in
// .spec.configuration.clusters.layout.shards.internalReplication
func (n *Normalizer) normalizeShardInternalReplication(shard *chiv1.ChiShard) {
// Default value set to true
shard.InternalReplication = util.CastStringBoolToStringTrueFalse(shard.InternalReplication, true)
defaultInternalReplication := false
if shard.ReplicasCount > 1 {
defaultInternalReplication = true
}
shard.InternalReplication = util.CastStringBoolToStringTrueFalse(shard.InternalReplication, defaultInternalReplication)
}

// normalizeDefaultsReplicasUseFQDN ensures chiv1.ChiDefaults.ReplicasUseFQDN section has proper values
Expand Down