Skip to content

fix build script to adapt to macos m1.#1169

Merged
Slach merged 1 commit intoAltinity:0.21.2from
xiedeyantu:fix-build-script
Jun 6, 2023
Merged

fix build script to adapt to macos m1.#1169
Slach merged 1 commit intoAltinity:0.21.2from
xiedeyantu:fix-build-script

Conversation

@xiedeyantu
Copy link
Copy Markdown
Contributor

@xiedeyantu xiedeyantu commented Jun 6, 2023

Important items to consider before making a Pull Request

Please check items PR complies to:

  • All commits in the PR are squashed. More info
  • The PR is made into dedicated next-release branch, not into master branch1. More info
  • The PR is signed. More info

--

1 If you feel your PR does not affect any Go-code or any testable functionality (for example, PR contains docs only or supplementary materials), PR can be made into master branch, but it has to be confirmed by project's maintainer.

@Slach Slach changed the base branch from master to 0.21.2 June 6, 2023 14:12
@Slach Slach self-requested a review June 6, 2023 14:13
@Slach Slach merged commit cbcf357 into Altinity:0.21.2 Jun 6, 2023
@xiedeyantu
Copy link
Copy Markdown
Contributor Author

@Slach Hi, what development model is clickhouse operator? Why merge to the 0.21.2 branch first instead of the master?

@Slach
Copy link
Copy Markdown
Collaborator

Slach commented Jun 6, 2023

@xiedeyantu
Copy link
Copy Markdown
Contributor Author

https://github.com/Altinity/clickhouse-operator/blob/master/CONTRIBUTING.md#how-to-make-pr

OK, thanks. Wait until the version is released before merging into the master branch, right?

@Slach
Copy link
Copy Markdown
Collaborator

Slach commented Jun 6, 2023

yep

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants