Fix nil pointer deref in metrics exporter (#1187) #1188
Merged
sunsingerus merged 1 commit intoAltinity:0.21.3from Jul 7, 2023
zcross:zcross/bugfix-npe-issue-1187
Merged
Fix nil pointer deref in metrics exporter (#1187) #1188sunsingerus merged 1 commit intoAltinity:0.21.3from zcross:zcross/bugfix-npe-issue-1187
sunsingerus merged 1 commit intoAltinity:0.21.3from
zcross:zcross/bugfix-npe-issue-1187
Conversation
…s() access Signed-off-by: Zach Cross <[email protected]>
Contributor
Author
|
Meta: it would seem to be going against the trend to add some highly specific unit test for this, so I'm going to let integration tests "cover it" ... although they didn't catch its first introduction (possibly due to the self-healing / temporal element of the "status" state). I made this quick edit in a text editor so I'm crossing my fingers for a green build :) |
sunsingerus
approved these changes
Jul 7, 2023
Contributor
Author
|
Whoops: I'll fire this up on my actual development machine and fix that now |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a very targeted fix for the NPE shown in #1187 since it's a known problem. The general pattern of guarding status lookups may be worth thinking about. Maybe we just need an intermediate type that decouples the application level usage of this state from its serialization/deserialization, at which point we can use basic language features like field visibility to reduce the probability of future unsafe accesses.
Important items to consider before making a Pull Request
Please check items PR complies to:
next-releasebranch, not intomasterbranch1. More info