Able to import packages with operator APIs#1229
Merged
sunsingerus merged 1 commit intoAltinity:0.23.3from Feb 15, 2024
Merged
Conversation
1628a3a to
74b626a
Compare
|
I'm having the same problem and am looking forward to the merging of this feature |
Contributor
Author
|
@sunsingerus could you please to have a look at this PR |
Signed-off-by: Dmitry Volodin <[email protected]>
74b626a to
ba6ff47
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #907
This fix allows you to do import an operator APIs to the third party tools based on golang.
The motivation of this PR: we are using Alinity ClickHouse operator and plan to embedded an operator APIs inside the our internal automation tool bases on golang (without plain yaml manipulation). It would be nice to import it without additional steps (forks, refactoring, plain yaml or Unstructured manipulations). Of cause, versions compatibility validation will be our or future uses pain in this case. If some code snippets need to be disabled for import, I can raise a PR to move them to an "internal" package.
Thanks in advance.
Thanks for taking the time to contribute to
clickhouse-operator!Please, read carefully instructions on how to make a Pull Request.
This will help a lot for maintainers to adopt your Pull Request.
Important items to consider before making a Pull Request
Please check items PR complies to:
next-releasebranch, not intomasterbranch1. More info--
1 If you feel your PR does not affect any Go-code or any testable functionality (for example, PR contains docs only or supplementary materials), PR can be made into
masterbranch, but it has to be confirmed by project's maintainer.