Upgrade ClickHouse version to 23.8-lts by orginux · Pull Request #1338 · Altinity/clickhouse-operator

orginux · 2024-02-08T18:13:32Z

Signed-off-by: Denis Gorobets [email protected]

Important items to consider before making a Pull Request

Please check items PR complies to:

All commits in the PR are squashed. More info
The PR is made into dedicated next-release branch, not into master branch¹. More info
The PR is signed. More info

--

¹ If you feel your PR does not affect any Go-code or any testable functionality (for example, PR contains docs only or supplementary materials), PR can be made into master branch, but it has to be confirmed by project's maintainer.

Slach · 2024-02-09T07:23:19Z

just search and replace version in yaml files is not enough, it could break something like test which use

some files shall to be excluded

Slach

please rollback changes in some files and use properly versions in some other

Slach · 2024-02-09T07:25:40Z

        containers:
        - name: clickhouse-pod
-          image: clickhouse/clickhouse-server:22.3
+          image: clickhouse/clickhouse-server:23.8


23.3 shall be here

Slach · 2024-02-09T07:26:23Z

        containers:
        - name: clickhouse-pod
-          image: clickhouse/clickhouse-server:22.3
+          image: clickhouse/clickhouse-server:23.8


23.3 shall be here

Slach · 2024-02-09T07:26:42Z

        containers:
        - name: clickhouse-pod
-          image: clickhouse/clickhouse-server:22.3
+          image: clickhouse/clickhouse-server:23.8


Slach · 2024-02-09T07:27:31Z

          containers:
            - name: clickhouse
-              image: clickhouse/clickhouse-server:21.8
+              image: clickhouse/clickhouse-server:23.8


Slach · 2024-02-09T07:29:27Z

          containers:
            - name: clickhouse-pod
-              image: clickhouse/clickhouse-server:22.1
+              image: clickhouse/clickhouse-server:23.8


Slach · 2024-02-09T07:33:16Z

          containers:
            - name: clickhouse-pod
-              image: clickhouse/clickhouse-server:22.2
+              image: clickhouse/clickhouse-server:23.8


rollback it

Slach · 2024-02-09T07:33:29Z

          containers:
            - name: clickhouse-pod
-              image: clickhouse/clickhouse-server:22.3
+              image: clickhouse/clickhouse-server:23.8


rollback it

Slach · 2024-02-09T07:33:40Z

          containers:
            - name: clickhouse-pod
-              image: clickhouse/clickhouse-server:22.6
+              image: clickhouse/clickhouse-server:23.8


rollback it

Slach · 2024-02-09T07:33:50Z

          containers:
            - name: clickhouse-pod
-              image: clickhouse/clickhouse-server:22.7
+              image: clickhouse/clickhouse-server:23.8


rollback it

Slach · 2024-02-09T07:34:01Z

          containers:
            - name: clickhouse-pod
-              image: clickhouse/clickhouse-server:22.8
+              image: clickhouse/clickhouse-server:23.8


rollback it

add separate tpl-clickhouse-23.8.yaml

and look references to tpl in tests

As far as I can see the file is already present: https://github.com/Altinity/clickhouse-operator/blob/master/tests/e2e/manifests/chit/tpl-clickhouse-23.8.yaml

Slach

please sync template images with templates names and link to these template names in other parts of manifests

Slach · 2024-02-09T09:35:48Z

-              image: clickhouse/clickhouse-server:22.1
+              image: clickhouse/clickhouse-server:22.8

      - name: clickhouse:22.2


sync version with template names in this file

sync names in line 23, 18, 13 above

Slach · 2024-02-09T09:36:36Z

          containers:
            - name: clickhouse-pod
-              image: clickhouse/clickhouse-server:22.1
+              image: clickhouse/clickhouse-server:22.8


sync version with name in podTemplates, look line 23, 18, 13

Slach · 2024-02-09T09:37:19Z

          containers:
            - name: clickhouse-pod
-              image: clickhouse/clickhouse-server:22.2
+              image: clickhouse/clickhouse-server:23.8


sync version with podTemplates name, line 10 and line 20

Slach · 2024-02-09T09:38:12Z

          containers:
            - name: clickhouse-pod
-              image: clickhouse/clickhouse-server:22.3
+              image: clickhouse/clickhouse-server:23.8


sync version with PodTemplates name

look also usage of this podTemplate above in the same file

Slach · 2024-02-09T09:42:15Z

          containers:
            - name: clickhouse-pod
-              image: clickhouse/clickhouse-server:22.3
+              image: clickhouse/clickhouse-server:23.8


sync podTemplates name and look to usage changed template name in spec default line 11

Slach · 2024-02-09T11:27:31Z

          containers:
            - name: clickhouse
-              image: clickhouse/clickhouse-server:22.3
+              image: clickhouse/clickhouse-server:23.8


look above to template name line 489, sync it

Slach · 2024-02-09T11:28:28Z

          containers:
            - name: clickhouse
-              image: clickhouse/clickhouse-server:22.2
+              image: clickhouse/clickhouse-server:23.8


change template name in line 593 and find usages of this template

Slach · 2024-02-09T11:30:35Z

          containers:
            - name: clickhouse
-              image: clickhouse/clickhouse-server:22.3
+              image: clickhouse/clickhouse-server:23.8


sync description in line 543 and 542 with actual clickhouse version

Slach · 2024-02-09T11:31:49Z

          containers:
            - name: clickhouse-pod
-              image: clickhouse/clickhouse-server:22.3
+              image: clickhouse/clickhouse-server:23.8


sync with name in line 47 and find usages this template and change template name reference too

Slach · 2024-02-09T11:42:08Z

        containers:
        - name: clickhouse-pod
-          image: clickhouse/clickhouse-server:22.8-broken
+          image: clickhouse/clickhouse-server:23.8-broken


sync with line 11 and 8

upgrade ch version

9c59e70

Slach requested changes Feb 9, 2024

View reviewed changes

orginux added 2 commits February 9, 2024 10:16

rollback some changes

5402be0

rollback some changes

8a4fb2e

Slach requested changes Feb 9, 2024

View reviewed changes

alex-zaitsev merged commit a651338 into Altinity:0.23.1 Feb 12, 2024

alex-zaitsev added a commit that referenced this pull request Feb 12, 2024

Continuation of #1338. Fix version in docs.

a1843ca

Conversation

orginux commented Feb 8, 2024

Important items to consider before making a Pull Request

Uh oh!

Slach commented Feb 9, 2024

Uh oh!

Slach left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Slach left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants