Added prometheus zeros init for reconciliation metrics#1398
Merged
sunsingerus merged 1 commit intoAltinity:0.24.0from Apr 24, 2024
Merged
Added prometheus zeros init for reconciliation metrics#1398sunsingerus merged 1 commit intoAltinity:0.24.0from
sunsingerus merged 1 commit intoAltinity:0.24.0from
Conversation
Signed-off-by: Neven Miculinic <[email protected]>
419d6c8 to
2beff6c
Compare
Author
|
I'm not exactly which branch should I target for I'd love to have additional gauge metric telling me last status of all CHI resources, though it may be a bit more work to get it (i.e. list all CHIs in the watched namespace, and set the right gauge in observable). This would be used for alerting systems. Not sure will I have time to do it |
Collaborator
|
@Slach I'll take a look and merge myself |
sunsingerus
approved these changes
Apr 24, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for taking the time to contribute to
clickhouse-operator!Please, read carefully instructions on how to make a Pull Request.
This will help a lot for maintainers to adopt your Pull Request.
Important items to consider before making a Pull Request
Please check items PR complies to:
next-releasebranch, not intomasterbranch1. More info--
1 If you feel your PR does not affect any Go-code or any testable functionality (for example, PR contains docs only or supplementary materials), PR can be made into
masterbranch, but it has to be confirmed by project's maintainer.